public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: carlos.song@nxp.com
Cc: aisheng.dong@nxp.com, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, xiaoning.wang@nxp.com, haibo.chen@nxp.com,
	linux-imx@nxp.com, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work
Date: Wed, 26 Jul 2023 16:58:23 +0200	[thread overview]
Message-ID: <20230726145823.y67dylomsgblaaww@intel.intel> (raw)
In-Reply-To: <20230726092238.3424116-1-carlos.song@nxp.com>

Hi Carlos,

On Wed, Jul 26, 2023 at 05:22:38PM +0800, carlos.song@nxp.com wrote:
> From: Carlos Song <carlos.song@nxp.com>
> 
> On MX8X platforms, the default clock rate is 0 if without explicit
> clock setting in dts nodes. I2c can't work when i2c peripheral clk
> rate is 0.
> 
> Add a i2c peripheral clk rate check before configuring the clock
> register. When i2c peripheral clk rate is 0 and directly return
> -EINVAL.
> 
> Signed-off-by: Carlos Song <carlos.song@nxp.com>

you are missing here:

Acked-by: Dong Aisheng <Aisheng.dong@nxp.com>

You can also add:

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

(no need to resend)

Thanks!
Andi

  reply	other threads:[~2023-07-26 14:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26  9:22 [PATCH v5] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work carlos.song
2023-07-26 14:58 ` Andi Shyti [this message]
2023-08-02 20:02 ` Andi Shyti
2023-08-14 13:24 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230726145823.y67dylomsgblaaww@intel.intel \
    --to=andi.shyti@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=carlos.song@nxp.com \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox