From: Harry Geyer <harry.geyer@devtank.co.uk>
To: Till Harbaum <till@harbaum.org>,
Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: harry.geyer@devtank.co.uk
Subject: [PATCH] i2c: tiny-usb: check usb base class before assuming the interface on device is for this driver
Date: Thu, 27 Jul 2023 09:33:54 +0100 [thread overview]
Message-ID: <20230727083354.4903-1-harry.geyer@devtank.co.uk> (raw)
Patch allows usb devices with multiple interfaces to use this driver without
this driver assuming all interfaces are i2c-tiny-usb.
Signed-off-by: Harry Geyer <harry.geyer@devtank.co.uk>
---
drivers/i2c/busses/i2c-tiny-usb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/busses/i2c-tiny-usb.c b/drivers/i2c/busses/i2c-tiny-usb.c
index d1fa9ff5aeab..d6578e8908ac 100644
--- a/drivers/i2c/busses/i2c-tiny-usb.c
+++ b/drivers/i2c/busses/i2c-tiny-usb.c
@@ -222,6 +222,9 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface,
int retval = -ENOMEM;
u16 version;
+ if (interface->intf_assoc && interface->intf_assoc->bFunctionClass != USB_CLASS_VENDOR_SPEC)
+ return -ENODEV;
+
dev_dbg(&interface->dev, "probing usb device\n");
/* allocate memory for our device state and initialize it */
--
2.34.1
next reply other threads:[~2023-07-27 8:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 8:33 Harry Geyer [this message]
2023-07-27 11:30 ` [PATCH] i2c: tiny-usb: check usb base class before assuming the interface on device is for this driver Andi Shyti
2023-07-27 13:54 ` Harry Geyer
2023-07-27 16:00 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2023-07-27 16:22 Harry Geyer
2023-07-27 17:13 ` Andi Shyti
2023-08-02 20:02 ` Andi Shyti
2023-08-14 13:17 ` Wolfram Sang
2023-07-19 11:38 Harry Geyer
2023-07-26 16:08 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727083354.4903-1-harry.geyer@devtank.co.uk \
--to=harry.geyer@devtank.co.uk \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=till@harbaum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox