From: Conor Dooley <conor.dooley@microchip.com>
To: Chen Jiahao <chenjiahao16@huawei.com>
Cc: <daire.mcnamara@microchip.com>, <andi.shyti@kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH -next] i2c: microchip-corei2c: clean up redundant dev_err_probe()
Date: Fri, 28 Jul 2023 09:44:30 +0100 [thread overview]
Message-ID: <20230728-serotonin-anointer-1771952f3baf@wendy> (raw)
In-Reply-To: <20230728083137.3528303-1-chenjiahao16@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Fri, Jul 28, 2023 at 04:31:37PM +0800, Chen Jiahao wrote:
> Referring to platform_get_irq()'s definition, the return value has
> already been checked, error message also been printed via
> dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
> outside platform_get_irq() is obviously redundant.
>
> Furthermore, platform_get_irq() will never return irq equals 0,
> removing spi->irq == 0 checking to clean it up.
>
> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-07-28 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 8:31 [PATCH -next] i2c: microchip-corei2c: clean up redundant dev_err_probe() Chen Jiahao
2023-07-28 8:44 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728-serotonin-anointer-1771952f3baf@wendy \
--to=conor.dooley@microchip.com \
--cc=andi.shyti@kernel.org \
--cc=chenjiahao16@huawei.com \
--cc=daire.mcnamara@microchip.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox