From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A39C04A6A for ; Tue, 1 Aug 2023 21:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232421AbjHAVgB (ORCPT ); Tue, 1 Aug 2023 17:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232314AbjHAVf6 (ORCPT ); Tue, 1 Aug 2023 17:35:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93B06172B; Tue, 1 Aug 2023 14:35:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21C8A6172A; Tue, 1 Aug 2023 21:35:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1012CC433C8; Tue, 1 Aug 2023 21:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690925755; bh=fHfxCcsWpP1oOquFycL9ZEIYSEN1iAuhitzxUtOffx8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GfNiL1ISHwCiSdCn5vzcBNCBghBFFbDb9e5n2NseFPYeoCwZXEQDXunHk8kCEdbhx xmtCG4qsDR4zaPAcLd7WOe0/L38kkFsyxQNNOuPaxFesf88RF3drcCyrEL1M+lw8cJ yJnwCE740/SXaaB0PniHQk/B9fUuGpwShpkixFOSoOpK2UhXuZqs4e3IgkiwImiR0W CIwD8iHyWJ3DiVe3BgaNmzTXbAs5xqE/s3EwXIgto9D7Z5rC1mMHFC0I481w1YuI8R 6bY5WEpuGk9CNvYBi+gswic30Q20tuv6wplnv5v9YeBo66EgfDbr+anUaEqmMRvybA mA8rBtnm6b7mg== Date: Tue, 1 Aug 2023 23:35:52 +0200 From: Andi Shyti To: Liao Chang Cc: florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/9] i2c: xlp9xx: Use dev_err_probe in probe function Message-ID: <20230801213552.u5qfsxaw36ayyaej@intel.intel> References: <20230728013148.1720978-1-liaochang1@huawei.com> <20230728013148.1720978-4-liaochang1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230728013148.1720978-4-liaochang1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Liao, On Fri, Jul 28, 2023 at 09:31:42AM +0800, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. > > Signed-off-by: Liao Chang Reviewed-by: Andi Shyti Andi