Re: [PATCH v3 2/2] i2c: Add i2c_device_get_match_data() callback

[kernel test robot <lkp@intel.com>]

Hi Biju,

kernel test robot noticed the following build errors:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus linus/master v6.5-rc4 next-20230801]
[cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Biju-Das/drivers-fwnode-Extend-device_get_match_data-to-struct-bus_type/20230802-010931
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
patch link:    https://lore.kernel.org/r/20230801170318.82682-3-biju.das.jz%40bp.renesas.com
patch subject: [PATCH v3 2/2] i2c: Add i2c_device_get_match_data() callback
config: parisc-randconfig-r026-20230731 (https://download.01.org/0day-ci/archive/20230802/202308021202.uZeI7Cnt-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230802/202308021202.uZeI7Cnt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308021202.uZeI7Cnt-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/i2c/i2c-core-base.c:23:
   include/linux/i2c.h:1038:2: error: redefinition of 'i2c_of_match_device'
    1038 | *i2c_of_match_device(const struct of_device_id *matches,
         |  ^~~~~~~~~~~~~~~~~~~
   include/linux/i2c.h:1031:2: note: previous definition of 'i2c_of_match_device' with type 'const struct of_device_id *(const struct of_device_id *, struct i2c_client *)'
    1031 | *i2c_of_match_device(const struct of_device_id *matches,
         |  ^~~~~~~~~~~~~~~~~~~
   drivers/i2c/i2c-core-base.c: In function 'i2c_device_get_match_data':
>> drivers/i2c/i2c-core-base.c:146:25: error: implicit declaration of function 'i2c_of_match_device_sysfs'; did you mean 'i2c_of_match_device'? [-Werror=implicit-function-declaration]
     146 |                 match = i2c_of_match_device_sysfs(dev->driver->of_match_table,
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                         i2c_of_match_device
>> drivers/i2c/i2c-core-base.c:146:23: warning: assignment to 'const struct of_device_id *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     146 |                 match = i2c_of_match_device_sysfs(dev->driver->of_match_table,
         |                       ^
   cc1: some warnings being treated as errors


vim +146 drivers/i2c/i2c-core-base.c

   128	
   129	static const void *i2c_device_get_match_data(const struct device *dev)
   130	{
   131		/* TODO: use i2c_verify_client() when it accepts const pointer */
   132		const struct i2c_client *client = (dev->type == &i2c_client_type) ?
   133						  to_i2c_client(dev) : NULL;
   134		const void *data;
   135	
   136		if (!dev->driver)
   137			return NULL;
   138	
   139		data = i2c_get_match_data_helper(to_i2c_driver(dev->driver), client);
   140		if (data)
   141			return data;
   142	
   143		if (dev->driver->of_match_table) {
   144			const struct of_device_id *match;
   145	
 > 146			match = i2c_of_match_device_sysfs(dev->driver->of_match_table,
   147							  (struct i2c_client *)client);
   148			if (match)
   149				data = match->data;
   150		}
   151	
   152		return data;
   153	}
   154	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki