From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70770C001DE for ; Fri, 4 Aug 2023 21:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbjHDVbc (ORCPT ); Fri, 4 Aug 2023 17:31:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229891AbjHDVbO (ORCPT ); Fri, 4 Aug 2023 17:31:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0A29115; Fri, 4 Aug 2023 14:31:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 64356620E3; Fri, 4 Aug 2023 21:31:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76B43C433C7; Fri, 4 Aug 2023 21:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691184667; bh=vlmb1ZjZSd8zw8ZbHxdcAEoIO5FvvTkVdffDkcMK2JU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eHQbNPfkutAvVNj+mEwT5sE7Ijp7fAjOnl8mCmexAUaGJDiwQMCe7KW6LtlaqI8rb CYBOfEfxMhmIZOwB1MEJaLDieL/QCTKGx7urZWnNHU2/4g8RzXms3yg6C48RWtRKzX rNTSZsV4ZKQZM3sDzY330Ks+PSPBWczYD+5pvwTIIoBZ63+TC6pQ0DUtqa3+9BBd6Z 6BlMK6OSppW+y8NEzNh7Hcbc2gMHdsIRjzYkFgXLmYoxeIGYpWIbOx0PR326DwdUEU Y3sqDcP+hqLzvrFCmr3L/9uJteruRr2IYxqF6D1wi4BBrMFyl/fjV3B1r+dkaE1vi2 CDeia0KZR+y6w== Date: Fri, 4 Aug 2023 23:31:05 +0200 From: Andi Shyti To: Andy Shevchenko Cc: Jarkko Nikula , Mario Limonciello , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Jan Dabros Subject: Re: [PATCH v1 7/9] i2c: desingware: Unify firmware type checks Message-ID: <20230804213105.r5lmf2dsdxyecyfm@intel.intel> References: <20230725143023.86325-1-andriy.shevchenko@linux.intel.com> <20230725143023.86325-8-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725143023.86325-8-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Andy, On Tue, Jul 25, 2023 at 05:30:21PM +0300, Andy Shevchenko wrote: > Instead of asymmetrical checks for the firmware use is_*_node() > calls. With that, drop now local wrappers against > > Signed-off-by: Andy Shevchenko > --- > drivers/i2c/busses/i2c-designware-common.c | 23 +++++++--------------- > 1 file changed, 7 insertions(+), 16 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c > index 443426474cfc..e6df6a484955 100644 > --- a/drivers/i2c/busses/i2c-designware-common.c > +++ b/drivers/i2c/busses/i2c-designware-common.c > @@ -241,15 +241,9 @@ static void i2c_dw_of_do_configure(struct dw_i2c_dev *dev, struct device *device > } > } > > -static void i2c_dw_of_configure(struct dw_i2c_dev *dev) > -{ > - if (dev_of_node(dev->dev)) > - i2c_dw_of_do_configure(dev, dev->dev); > -} > - I have to partially agree with Jarkko here, the patch splitting of this series is a bit too exotic. Series need to be understood by reading them forward, not backward. Oversplitting sometimes might even reduce readability and "reviewability" (can I say so?). And this function, in seven patches, has been added, moved and removed, and I had to read the series twice :) Anyway, I won't ask you to refactor the whole series, I understand your logic. Reviewed-by: Andi Shyti Andi