Re: [PATCH v3 8/9] i2c: imx-lpi2c: Use dev_err_probe in probe function

Krzysztof Kozlowski
2023-08-08T16:57:52Z

On 08/08/2023 03:29, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
>

> ret = devm_request_irq(&pdev->dev, irq, lpi2c_imx_isr, 0,
> pdev->name, lpi2c_imx);
> - if (ret) {
> - dev_err(&pdev->dev, "can't claim irq %d\n", irq);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "can't claim irq %d\n", irq);
>

I don't think this is needed:
https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/

Best regards,
Krzysztof