Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe function

Andi Shyti
2023-08-09T19:22:31Z

Hi Liao,

On Tue, Aug 08, 2023 at 09:29:54AM +0800, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
>
> Signed-off-by: Liao Chang <liaochang1@huawei.com>

After some discussions and time, I think it's right to r-b this
patch. If you agree more with Krzysztof, feel free to follow his
recommendation and send another version otherwise I will go ahead
and take this series in my branch. I do not really mind, both
arguments are valid.

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thanks,
Andi