Re: [PATCH v3 5/9] i2c: qcom-cci: Use dev_err_probe in probe function

Bjorn Andersson
2023-08-10T15:06:39Z

On Tue, Aug 08, 2023 at 09:29:50AM +0800, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
>
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
> Signed-off-by: Liao Chang <liaochang1@huawei.com>
> ---
> drivers/i2c/busses/i2c-qcom-cci.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
> index 622dc14add9d..cf13abec05f1 100644
> --- a/drivers/i2c/busses/i2c-qcom-cci.c
> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
> @@ -588,10 +588,8 @@ static int cci_probe(struct platform_device *pdev)
> /* Clocks */
>
> ret = devm_clk_bulk_get_all(dev, &cci->clocks);
> - if (ret < 1) {
> - dev_err(dev, "failed to get clocks %d\n", ret);
> - return ret;
> - }
> + if (ret < 1)
> + return dev_err_probe(dev, ret, "failed to get clocks\n");

devm_clk_bulk_get_all() will already have printed a more useful/specific
error message. Unfortunately will not be carried as the deferred probe
reason, but this error will just indicate that some clock controller
wasn't ready...

TL;DR I think we should just drop the error print from here instead.

Regards,
Bjorn