Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe function

Andi Shyti
2023-08-10T08:11:01Z

Hi Liao,

On Thu, Aug 10, 2023 at 10:33:58AM +0800, Liao, Chang wrote:
> Hi Andi and Krzysztof,
>
> 在 2023/8/10 3:21, Andi Shyti 写道:
> > Hi Liao,
> >
> > On Tue, Aug 08, 2023 at 09:29:54AM +0800, Liao Chang wrote:
> >> Use the dev_err_probe function instead of dev_err in the probe function
> >> so that the printed messge includes the return value and also handles
> >> -EPROBE_DEFER nicely.
> >>
> >> Signed-off-by: Liao Chang <liaochang1@huawei.com>
> >
> > After some discussions and time, I think it's right to r-b this
> > patch. If you agree more with Krzysztof, feel free to follow his
> > recommendation and send another version otherwise I will go ahead
> > and take this series in my branch. I do not really mind, both
> > arguments are valid.
>
> I saw that Frank Li developed some new APIs that look like they would be very
> helpful for aligning the error messages of devm_request_irq in device probes.
> However, the patches have been pending for weeks and the author hasn't sent a
> new version. So I'm not planning to switch to the new APIs in this patch series,
> if there are no objections.
>
> Do I need to resend a new revision to add your R-B at this patch?

no, no need. I'm also going to fix a typo in the commit message
(messge/message) that Markus has pointed out.

Thanks for this series of cleanups,
Andi

> Thanks.
>
> >
> > Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
> >
> > Thanks,
> > Andi
>
> --
> BR
> Liao, Chang