Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe function

Krzysztof Kozlowski
2023-08-08T16:14:25Z

On 08/08/2023 03:29, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
>
> Signed-off-by: Liao Chang <liaochang1@huawei.com>

> i2c->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(i2c->base))
> @@ -582,10 +578,8 @@ static int synquacer_i2c_probe(struct platform_device *pdev)
>
> ret = devm_request_irq(&pdev->dev, i2c->irq, synquacer_i2c_isr,
> 0, dev_name(&pdev->dev), i2c);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "cannot claim IRQ %d\n", i2c->irq);
> - return ret;
> - }
> + if (ret < 0)
> + return dev_err_probe(&pdev->dev, ret, "cannot claim IRQ %d\n", i2c->irq);
>

I don't think this is needed:
https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/

Best regards,
Krzysztof