Linux I2C development
 help / color / mirror / Atom feed
From: Liao Chang <liaochang1@huawei.com>
To: <andi.shyti@kernel.org>, <florian.fainelli@broadcom.com>,
	<rjui@broadcom.com>, <sbranden@broadcom.com>,
	<bcm-kernel-feedback-list@broadcom.com>,
	<yangyicong@hisilicon.com>, <aisheng.dong@nxp.com>,
	<shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
	<kernel@pengutronix.de>, <festevam@gmail.com>,
	<linux-imx@nxp.com>, <kblaiech@nvidia.com>, <asmaa@nvidia.com>,
	<loic.poulain@linaro.org>, <rfoss@kernel.org>, <ardb@kernel.org>,
	<gcherian@marvell.com>
Cc: <linux-i2c@vger.kernel.org>,
	<linux-rpi-kernel@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: [PATCH v3 4/9] i2c: hisi: Use dev_err_probe in probe function
Date: Tue, 8 Aug 2023 09:29:49 +0800	[thread overview]
Message-ID: <20230808012954.1643834-5-liaochang1@huawei.com> (raw)
In-Reply-To: <20230808012954.1643834-1-liaochang1@huawei.com>

Use the dev_err_probe function instead of dev_err in the probe function
so that the printed messge includes the return value and also handles
-EPROBE_DEFER nicely.

Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
Signed-off-by: Liao Chang <liaochang1@huawei.com>
---
 drivers/i2c/busses/i2c-hisi.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c
index e067671b3ce2..6fc8d6fa43b6 100644
--- a/drivers/i2c/busses/i2c-hisi.c
+++ b/drivers/i2c/busses/i2c-hisi.c
@@ -462,18 +462,14 @@ static int hisi_i2c_probe(struct platform_device *pdev)
 	hisi_i2c_disable_int(ctlr, HISI_I2C_INT_ALL);
 
 	ret = devm_request_irq(dev, ctlr->irq, hisi_i2c_irq, 0, "hisi-i2c", ctlr);
-	if (ret) {
-		dev_err(dev, "failed to request irq handler, ret = %d\n", ret);
-		return ret;
-	}
+	if (ret)
+		return dev_err_probe(dev, ret, "failed to request irq handler\n");
 
 	ctlr->clk = devm_clk_get_optional_enabled(&pdev->dev, NULL);
 	if (IS_ERR_OR_NULL(ctlr->clk)) {
 		ret = device_property_read_u64(dev, "clk_rate", &clk_rate_hz);
-		if (ret) {
-			dev_err(dev, "failed to get clock frequency, ret = %d\n", ret);
-			return ret;
-		}
+		if (ret)
+			return dev_err_probe(dev, ret, "failed to get clock frequency\n");
 	} else {
 		clk_rate_hz = clk_get_rate(ctlr->clk);
 	}
-- 
2.25.1


  parent reply	other threads:[~2023-08-08  1:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  1:29 [PATCH v3 0/9] Use dev_err_probe in i2c probe function Liao Chang
2023-08-08  1:29 ` [PATCH v3 1/9] i2c: bcm2835: Use dev_err_probe in " Liao Chang
     [not found]   ` <1f23c942-5a6a-4b23-9067-79f5db93021b@web.de>
2023-08-08 11:31     ` Andi Shyti
2023-08-08  1:29 ` [PATCH v3 2/9] i2c: mlxbf: " Liao Chang
2023-08-08  8:36   ` Krzysztof Kozlowski
2023-08-08 11:29     ` Andi Shyti
2023-08-08 11:31       ` Krzysztof Kozlowski
2023-08-08 11:47         ` Andi Shyti
2023-08-08 15:55           ` Krzysztof Kozlowski
2023-08-09  8:02             ` Andi Shyti
2023-08-08  1:29 ` [PATCH v3 3/9] i2c: xlp9xx: " Liao Chang
2023-08-08  8:36   ` Krzysztof Kozlowski
2023-08-08  1:29 ` Liao Chang [this message]
2023-08-08  8:36   ` [PATCH v3 4/9] i2c: hisi: " Krzysztof Kozlowski
2023-08-08  1:29 ` [PATCH v3 5/9] i2c: qcom-cci: " Liao Chang
2023-08-10 15:06   ` Bjorn Andersson
2023-08-08  1:29 ` [PATCH v3 6/9] i2c: pxa: " Liao Chang
2023-08-08  1:29 ` [PATCH v3 7/9] i2c: dln2: " Liao Chang
2023-08-08  1:29 ` [PATCH v3 8/9] i2c: imx-lpi2c: " Liao Chang
2023-08-08  8:37   ` Krzysztof Kozlowski
2023-08-08  1:29 ` [PATCH v3 9/9] i2c: synquacer: " Liao Chang
2023-08-08  8:37   ` Krzysztof Kozlowski
2023-08-09 19:21   ` Andi Shyti
2023-08-10  2:33     ` Liao, Chang
2023-08-10  8:10       ` Andi Shyti
2023-08-10  8:19 ` [PATCH v3 0/9] Use dev_err_probe in i2c " Andi Shyti
2023-08-14 15:16   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808012954.1643834-5-liaochang1@huawei.com \
    --to=liaochang1@huawei.com \
    --cc=aisheng.dong@nxp.com \
    --cc=andi.shyti@kernel.org \
    --cc=ardb@kernel.org \
    --cc=asmaa@nvidia.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=festevam@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=gcherian@marvell.com \
    --cc=kblaiech@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=loic.poulain@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=rjui@broadcom.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sbranden@broadcom.com \
    --cc=shawnguo@kernel.org \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox