Re: [PATCH] i2c: Drop legacy callback .probe_new()

[Lee Jones <lee@kernel.org>]

On Mon, 26 Jun 2023, Uwe Kleine-König wrote:

> Now that all drivers are converted to the (new) .probe() callback, the
> temporary .probe_new() can go away. \o/
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> I was planning to send out this patch for inclusion into next after
> v6.5-rc1 as I thought there were only three drivers left to be converted
> before (on top of today's next/master). While preparing to submit this
> patch I noticed that a few more .probe_new were introduced in next even
> after commit 03c835f498b5 ("i2c: Switch .probe() to not take an id
> parameter"). I just sent out patches for all drivers in next that are
> still using .probe_new. These are:
> 
>  - w1: ds2482: Switch back to use struct i2c_driver's .probe()
>    https://lore.kernel.org/lkml/20230612072807.839689-1-u.kleine-koenig@pengutronix.de
>    Krzysztof Kozlowski already signaled this won't go into 6.5-rc via
>    his tree, and he's ok if it goes in via i2c then.
> 
>  - drm/i2c: Switch i2c drivers back to use .probe()
>    https://lore.kernel.org/dri-devel/20230611202740.826120-1-u.kleine-koenig@pengutronix.de
>    Currently applied to
> 
> 	https://anongit.freedesktop.org/git/drm/drm-misc.git drm-misc-next
> 
>    as d13b5d2b2b45. This won't make it onto v6.5-rc1 either.
> 
>  - watchdog: ziirave_wdt: Switch i2c driver back to use .probe()
>    https://lore.kernel.org/linux-watchdog/20230525210837.735447-1-u.kleine-koenig@pengutronix.de
>    Given that the merge window is open now, I doubt this will make it
>    into v6.5-rc1.
> 
>  - c4cfa2436ff6 hwmon: max31827: Switch back to use struct i2c_driver::probe
>    https://lore.kernel.org/linux-hwmon/20230626085145.554616-1-u.kleine-koenig@pengutronix.de
> 
>  - leds: aw200xx: Switch back to use struct i2c_driver::probe
>    https://lore.kernel.org/linux-leds/20230626090254.556206-1-u.kleine-koenig@pengutronix.de
> 
>  - media: i2c: ov01a10: Switch back to use struct i2c_driver::probe
>    https://lore.kernel.org/linux-media/20230626090533.556406-1-u.kleine-koenig@pengutronix.de
> 
>  - usb: typec: nb7vpq904m: Switch back to use struct i2c_driver::probe
>    https://lore.kernel.org/linux-usb/20230626091314.557122-1-u.kleine-koenig@pengutronix.de
> 
>  - regulator: raa215300: Switch back to use struct i2c_driver::probe
>    https://lore.kernel.org/lkml/20230626091544.557403-1-u.kleine-koenig@pengutronix.de
> 
>  - mfd: Switch two more drivers back to use struct i2c_driver::probe
>    https://lore.kernel.org/lkml/20230626091941.557733-1-u.kleine-koenig@pengutronix.de
> 
> The last six were only sent today, so I guess we have to wait another
> development cycle and then get this patch into next after v6.6-rc1
> (together with the patches from above list that will have failed to get
> into v6.6-rc1).
> 
> Until we're there, feel free to already look at this patch. I was unsure
> if I should split of the change to Documentation/hwmon/pmbus.rst. As
> .probe() already works in v6.3-rc2 this hunk could go in already
> earlier, e.g. via the hwmon tree. While thinking about that, the hunk
> for Documentation/i2c/writing-clients.rst could go in before, too.
> So tell me your thoughts, then I can split as desired.
> 
> Best regards
> Uwe
> 
>  Documentation/hwmon/pmbus.rst         |  2 +-
>  Documentation/i2c/writing-clients.rst |  2 +-
>  include/linux/i2c.h                   | 11 +----------
>  3 files changed, 3 insertions(+), 12 deletions(-)

Reviewed-by: Lee Jones <lee@kernel.org>

-- 
Lee Jones [李琼斯]