From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-i2c-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3D7DFC27C40
	for <linux-i2c@archiver.kernel.org>; Thu, 24 Aug 2023 16:05:57 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S242347AbjHXQFZ (ORCPT <rfc822;linux-i2c@archiver.kernel.org>);
        Thu, 24 Aug 2023 12:05:25 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41130 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S242352AbjHXQFA (ORCPT
        <rfc822;linux-i2c@vger.kernel.org>); Thu, 24 Aug 2023 12:05:00 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD30D1993;
        Thu, 24 Aug 2023 09:04:58 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (2048 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 232C5660E0;
        Thu, 24 Aug 2023 16:04:58 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D915DC433C7;
        Thu, 24 Aug 2023 16:04:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1692893097;
        bh=2Xy8M/k7kw3fNCsthMZhjlbAgiSGbp7m946htAdUOQk=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=B79vycQTFME8yZcnKZihKjGm6lMnGMfhhvzCv036MklnqLmyDv+3yxt1z7NLsEJkI
         eMLLNfm/SAb+QjviHweAlID78OzwF2v4OgVmmo94DVt/Pi3MdS6Iz83jhZYMSGc4kn
         CeO7NAk+lOiMzD0tm11ssXvbC2crIl5VKCpv15FTVmPB3O1cCYkqfz9V15BQtVIdZ9
         hPKNI4iXkEfSVkl4TZ1wfuY35/vcAgSiZ3yJxotbmJFUMEpQKNP35N5n2KRgpD92bq
         e4hmR+tAjl8aXzLcID5yvEqamASiVnOHMfEBYh68TdYQ7K2Tt7WI3gjHO/tj6MXiga
         ZS6n9FkLsV5Yg==
Date:   Thu, 24 Aug 2023 18:04:53 +0200
From:   Andi Shyti <andi.shyti@kernel.org>
To:     Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
Cc:     linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
        Jean Delvare <jdelvare@suse.com>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/14] I2C: sis5595: Do PCI error checks on own line
Message-ID: <20230824160453.xehwsyllqvnyexqg@intel.intel>
References: <20230824132832.78705-1-ilpo.jarvinen@linux.intel.com>
 <20230824132832.78705-10-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230824132832.78705-10-ilpo.jarvinen@linux.intel.com>
Precedence: bulk
List-ID: <linux-i2c.vger.kernel.org>
X-Mailing-List: linux-i2c@vger.kernel.org

Hi Ilpo,

On Thu, Aug 24, 2023 at 04:28:27PM +0300, Ilpo Järvinen wrote:
> Instead of if conditions with line splits, use the usual error handling
> pattern with a separate variable to improve readability.
> 
> No functional changes intended.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Thanks,
Andi