Re: [PATCH v12 4/4] gpio: update Intel LJCA USB GPIO driver

Andi Shyti
2023-09-02T18:14:34Z

Hi Wentong,

> > On Fri, Sep 01, 2023 at 01:36:17PM +0800, Wentong Wu wrote:
> > > This driver communicate with LJCA GPIO module with specific protocol
> > > through interfaces exported by LJCA USB driver.
> > > Update the driver according to LJCA USB driver's changes.
> > >
> > > Signed-off-by: Wentong Wu <wentong.wu@intel.com>
> > > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > I am not understanding this patch... Looks like a collection of random to
> > relevant changes you did in gpio-ljca.c.
>
> This patch is following the changes of usb-ljca, from platform_device to
> auxiliary_device, and ljca_transfer API's change. And others are mainly
> coding style's change.

then please divide this into smaller commits. Cosmetic changes
should be in separate patches, and functional changes in
different commits. They should not be mixed together.

> > I'm not able to review this, can you please split it in minor changes?
> >
> > Meanwhile the previous patches should be able to work without this one, right?
>
> I don't think it can work without usb-ljca

I am actually asking about the reverse. Are we confident that
patches 1, 2, and 3 function correctly without this one? I didn't
notice any dependencies.

If that's the case, I would suggest removing this patch from the
series, merging patches 1, 2, and 3, and then addressing this
patch separately. It can be properly divided and expanded into a
more comprehensive series.

Andi