From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] i2c: rcar: remove open coded DIV_ROUND_CLOSEST
Date: Wed, 6 Sep 2023 22:00:22 +0200 [thread overview]
Message-ID: <20230906200024.5305-5-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20230906200024.5305-1-wsa+renesas@sang-engineering.com>
It improves readability if we use the available helper.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/busses/i2c-rcar.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index 2585092bed52..5e97635faf78 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -291,16 +291,15 @@ static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv)
ick = rate / (cdf + 1);
/*
- * it is impossible to calculate large scale
- * number on u32. separate it
+ * It is impossible to calculate a large scale number on u32. Separate it.
*
* F[(ticf + tr + intd) * ick] with sum = (ticf + tr + intd)
* = F[sum * ick / 1000000000]
* = F[(ick / 1000000) * sum / 1000]
*/
sum = t.scl_fall_ns + t.scl_rise_ns + t.scl_int_delay_ns;
- round = (ick + 500000) / 1000000 * sum;
- round = (round + 500) / 1000;
+ round = DIV_ROUND_CLOSEST(ick, 1000000);
+ round = DIV_ROUND_CLOSEST(round * sum, 1000);
/*
* SCL = ick / (20 + 8 * SCGD + F[(ticf + tr + intd) * ick])
--
2.35.1
next prev parent reply other threads:[~2023-09-06 20:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 20:00 [PATCH 0/5] i2c: clock calculation cleanups for Renesas devices Wolfram Sang
2023-09-06 20:00 ` [PATCH 1/5] i2c: rcar: avoid non-standard use of goto Wolfram Sang
2023-09-08 15:03 ` Geert Uytterhoeven
2023-09-06 20:00 ` [PATCH 2/5] i2c: rcar: properly format a debug output Wolfram Sang
2023-09-08 15:04 ` Geert Uytterhoeven
2023-09-06 20:00 ` [PATCH 3/5] i2c: rcar: calculate divider instead of brute-forcing it Wolfram Sang
2023-09-19 8:33 ` Geert Uytterhoeven
2023-09-06 20:00 ` Wolfram Sang [this message]
2023-09-08 15:06 ` [PATCH 4/5] i2c: rcar: remove open coded DIV_ROUND_CLOSEST Geert Uytterhoeven
2023-09-06 20:00 ` [PATCH 5/5] i2c: riic: avoid potential division by zero Wolfram Sang
2023-09-07 6:42 ` Biju Das
2023-09-07 6:44 ` Biju Das
2023-09-07 12:08 ` Wolfram Sang
2023-09-08 15:09 ` Geert Uytterhoeven
2023-09-19 9:12 ` [PATCH 0/5] i2c: clock calculation cleanups for Renesas devices Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906200024.5305-5-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox