From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D0DCDB46E for ; Thu, 12 Oct 2023 11:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347275AbjJLL6t (ORCPT ); Thu, 12 Oct 2023 07:58:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347273AbjJLL6k (ORCPT ); Thu, 12 Oct 2023 07:58:40 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 516BB658D for ; Thu, 12 Oct 2023 04:57:21 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 300FDC433C7; Thu, 12 Oct 2023 11:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697111840; bh=Yf+t1wmcZJPPp71FZpye5Mrtw06k0sUl2+puVNH65to=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LdQJMtI+s6l+ttGP71rwDlSIwflkOWvGT9hE80ZkA/LvyoR4dWP811j5H2/Hj9Zyz OOYVh+8anWRvoaKb4D0RX3Z7CoEV3X1SMMFkmH56EQBinl/nhL6w6bssrBemx128Yy uDsbs0cAPi+Q0HDYerLF4sZUXy6CuWeHuRkp5ifmfxIEQZF7vV/9ExsZs6nhvKuSQ6 tsNjYav2Bamrx5bkWLdnmTXXKoa6CZofeTw8E6zn40d+NK8xfEafBicgiv4TcKe3C5 IQuhofnx7JhyVwrNMIpg9IbmR7pbzkJF/Fy4KrbAq+tt5M0PNVbqH+zsmxElYjvU+s XVk4Vgt2nzzrw== Received: (nullmailer pid 293856 invoked by uid 1000); Thu, 12 Oct 2023 11:57:19 -0000 Date: Thu, 12 Oct 2023 06:57:19 -0500 From: Rob Herring To: Marek Vasut Cc: linux-i2c@vger.kernel.org, Arnd Bergmann , Bartosz Golaszewski , Conor Dooley , Greg Kroah-Hartman , Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: at24: add ST M24C32-D Additional Write lockable page Message-ID: <20231012115719.GA291445-robh@kernel.org> References: <20231010190926.57674-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010190926.57674-1-marex@denx.de> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Tue, Oct 10, 2023 at 09:09:25PM +0200, Marek Vasut wrote: > The ST M24C32-D behaves as a regular M24C32, except for the -D variant > which uses up another I2C address for Additional Write lockable page. > This page is 32 Bytes long and can contain additional data. Document > compatible string for it, so users can describe that page in DT. Note > that users still have to describe the main M24C32 area separately as > that is on separate I2C address from this page. So 2 nodes for 1 device? Wouldn't it make more sense for the 1 node to have 2 addresses? > > Signed-off-by: Marek Vasut > --- > Cc: Arnd Bergmann > Cc: Bartosz Golaszewski > Cc: Conor Dooley > Cc: Greg Kroah-Hartman > Cc: Krzysztof Kozlowski > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Cc: linux-i2c@vger.kernel.org > --- > Documentation/devicetree/bindings/eeprom/at24.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml > index 98139489d4b5c..7be127e9b2507 100644 > --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > @@ -67,6 +67,8 @@ properties: > pattern: cs16$ > - items: > pattern: c32$ > + - items: > + pattern: c32d-wl$ > - items: > pattern: cs32$ > - items: > -- > 2.40.1 >