public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH RFC] i2c: i801: Add i801_register_jc42, similar to i2c_register_spd
Date: Sun, 19 Nov 2023 09:39:02 +0100	[thread overview]
Message-ID: <20231119093902.739b4602@endymion.delvare> (raw)
In-Reply-To: <5f2ed562-319c-4439-a235-c1a01373c1fe@gmail.com>

Hi Heiner,

On Wed, 15 Nov 2023 12:00:18 +0100, Heiner Kallweit wrote:
> After thinking once more about it I think we have to do it from the
> ee1004 driver for DDR4. For DDR3 from at24. Only this way we can read
> the "temp sensor present" flag from SPD. E.g. for ee1004 the SPD EEPROM
> may be switched to the second page and we have to switch it to the first
> page first.

We indeed need to read the EEPROM data at some point. My initial
thinking was to instantiate the at24 or ee1004 device first (from
i2c-smbus), then read the value from the EEPROM and instantiate the
jc42 device (still from i2c-smbus). This requires an internal read
function. I think we already have that in at24, because it uses the
nvmem framework, but ee1004 lacks it as far as I can see.

But anyway, if you have another approach which works, that's equally
fine with me.

> I'll send a RFC patch for this. Unfortunately I have no RAM with temp
> sensor to test it.

Neither do I :-(

-- 
Jean Delvare
SUSE L3 Support

  reply	other threads:[~2023-11-19  8:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08  7:27 [PATCH RFC] i2c: i801: Add i801_register_jc42, similar to i2c_register_spd Heiner Kallweit
2023-11-08 10:28 ` Heiner Kallweit
2023-11-14 14:00   ` Jean Delvare
2023-11-14 14:44     ` Heiner Kallweit
2023-11-14 15:00       ` Heiner Kallweit
2023-11-15 11:00       ` Heiner Kallweit
2023-11-19  8:39         ` Jean Delvare [this message]
2023-11-21 12:34           ` Heiner Kallweit
2023-11-15 18:27       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231119093902.739b4602@endymion.delvare \
    --to=jdelvare@suse.de \
    --cc=hkallweit1@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox