From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Jani Nikula <jani.nikula@intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v5 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support
Date: Thu, 23 Nov 2023 10:40:35 +0100 [thread overview]
Message-ID: <20231123094040.592-16-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
index 40d7b6f3f..e9e4dcf34 100644
--- a/drivers/gpu/drm/i915/display/intel_gmbus.c
+++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
@@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915)
}
bus->adapter.owner = THIS_MODULE;
- bus->adapter.class = I2C_CLASS_DDC;
snprintf(bus->adapter.name,
sizeof(bus->adapter.name),
"i915 gmbus %s", gmbus_pin->name);
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index a636f42ce..5e64d1baf 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc,
ddc->ddc_bus = ddc_bus;
ddc->ddc.owner = THIS_MODULE;
- ddc->ddc.class = I2C_CLASS_DDC;
snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d",
port_name(sdvo->base.port), ddc_bus);
ddc->ddc.dev.parent = &pdev->dev;
next prev parent reply other threads:[~2023-11-23 9:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 9:40 [PATCH v5 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 03/20] drm/amd/display: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-24 7:37 ` Sui Jingfeng
2023-11-23 9:40 ` [PATCH v5 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` Heiner Kallweit [this message]
2023-11-23 11:14 ` [Intel-gfx] [PATCH v5 15/20] drivers/gpu/drm/i915/display: " Andi Shyti
2023-11-23 9:40 ` [PATCH v5 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-23 9:40 ` [PATCH v5 20/20] include/linux/i2c.h: " Heiner Kallweit
2023-11-23 21:33 ` [PATCH v5 00/20] " Wolfram Sang
2023-12-19 12:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123094040.592-16-hkallweit1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox