From: "Pali Rohár" <pali@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Jean Delvare" <jdelvare@suse.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Eric Piel" <eric.piel@tremplin-utc.net>,
"Paul Menzel" <pmenzel@molgen.mpg.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
Dell.Client.Kernel@dell.com, "Marius Hoch" <mail@mariushoch.de>,
"Kai Heng Feng" <kai.heng.feng@canonical.com>,
"Wolfram Sang" <wsa@kernel.org>,
platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 6/6] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address
Date: Sun, 24 Dec 2023 23:07:42 +0100 [thread overview]
Message-ID: <20231224220742.5cv2a7tdd4f2k4mt@pali> (raw)
In-Reply-To: <20231224213629.395741-7-hdegoede@redhat.com>
On Sunday 24 December 2023 22:36:22 Hans de Goede wrote:
> Unfortunately the SMOxxxx ACPI device does not contain the i2c-address
> of the accelerometer. So a DMI product-name to address mapping table
> is used.
>
> At support to have the kernel probe for the i2c-address for modesl
> which are not on the list.
>
> The new probing code sits behind a new probe_i2c_addr module parameter,
> which is disabled by default because probing might be dangerous.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
I would really like to hear Dell opinion about this change, and if there
is really no way to get i2c address. Could you ask Dell people about it?
Always it is better to use official / vendor provided steps of hardware
detection, instead of inventing something new / own which would be there
for a long time...
next prev parent reply other threads:[~2023-12-24 22:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 21:36 [PATCH 0/6] i2c-i801 / dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-smo8800 Hans de Goede
2023-12-24 21:36 ` [PATCH 1/6] platform/x86: dell-smo8800: Only load on Dell laptops Hans de Goede
2023-12-24 21:48 ` Pali Rohár
2024-01-05 16:25 ` Hans de Goede
2023-12-24 21:36 ` [PATCH 2/6] platform/x86: dell-smo8800: Change probe() ordering a bit Hans de Goede
2023-12-24 21:36 ` [PATCH 3/6] platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-smo8800 Hans de Goede
2023-12-24 21:55 ` Pali Rohár
2024-01-05 16:31 ` Hans de Goede
2024-01-05 18:26 ` Pali Rohár
2024-01-06 12:13 ` Hans de Goede
2024-01-06 12:16 ` Pali Rohár
2023-12-25 20:00 ` Andy Shevchenko
2024-01-08 9:40 ` kernel test robot
2023-12-24 21:36 ` [PATCH 4/6] platform/x86: dell-smo8800: Pass the IRQ to the lis3lv02d i2c_client Hans de Goede
2024-01-08 17:28 ` kernel test robot
2023-12-24 21:36 ` [PATCH 5/6] platform/x86: dell-smo8800: Instantiate an i2c_client for the IIO st_accel driver Hans de Goede
2023-12-24 22:03 ` Pali Rohár
2024-01-05 16:34 ` Hans de Goede
2024-01-05 18:33 ` Pali Rohár
2024-01-05 18:37 ` Andy Shevchenko
2024-01-05 19:04 ` Andy Shevchenko
2024-01-05 19:20 ` Pali Rohár
2024-01-05 19:46 ` Hans de Goede
2024-01-09 2:00 ` kernel test robot
2023-12-24 21:36 ` [PATCH 6/6] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address Hans de Goede
2023-12-24 22:07 ` Pali Rohár [this message]
2024-01-05 16:36 ` Hans de Goede
2024-01-05 18:51 ` Pali Rohár
2024-01-06 14:30 ` Hans de Goede
2024-01-08 13:22 ` Dell contacts (was: [PATCH 6/6] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address) Paul Menzel
2024-01-08 14:06 ` Greg KH
2024-01-06 14:23 ` [PATCH 0/6] i2c-i801 / dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-smo8800 Paul Menzel
2024-01-06 16:15 ` Hans de Goede
2024-01-08 11:29 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231224220742.5cv2a7tdd4f2k4mt@pali \
--to=pali@kernel.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=eric.piel@tremplin-utc.net \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mail@mariushoch.de \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox