Re: [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup()

Bjorn Helgaas
2024-01-29T22:24:19Z

On Mon, Jan 29, 2024 at 04:16:49PM -0600, Bjorn Helgaas wrote:
> On Fri, Jan 26, 2024 at 03:43:39PM -0600, Bjorn Helgaas wrote:
> > On Fri, Jan 26, 2024 at 03:36:55PM +0100, Thomas Richard wrote:
> > > From: Théo Lebrun <theo.lebrun@bootlin.com>
> > >
> > > That function mixes probe structure init and hardware config.
> > > The whole hardware config part must be done at resume after a suspend to
> > > ram.
> > > We therefore pass it a boolean flag determining if we are at probe or at
> > > resume.
> > ...

> > It'd be super nice to have them the same. Passing in a "probe" flag
> > works but seems a little harder to read in cdns_pcie_host_setup() and
> > you have to keep track of what it means in the callers.
>
> Maybe a better way to say this is that this patch uses the "probe"
> flag to select the behavior of cdns_pcie_host_setup(), and I think it
> would be nicer to split those two behaviors into separate functions.

Oops, sorry, Andy, I wrote this before I saw your similar response
from last Friday. Didn't mean to repeat what you already said!

Bjorn