Re: [PATCH v2 04/15] mux: add mux_chip_resume() function

Thomas Richard
2024-01-30T16:38:18Z

On 1/26/24 22:28, Andy Shevchenko wrote:
> On Fri, Jan 26, 2024 at 4:37 PM Thomas Richard
> <thomas.richard@bootlin.com> wrote:
>>
>> The mux_chip_resume() function restores a mux_chip using the cached state
>> of each mux.
>
> ...
>
>> +int mux_chip_resume(struct mux_chip *mux_chip)
>> +{
>> + int ret, i;
>> +
>> + for (i = 0; i < mux_chip->controllers; ++i) {
>> + struct mux_control *mux = &mux_chip->mux[i];
>
>> + if (mux->cached_state != MUX_CACHE_UNKNOWN) {
>
> if (_state == ...)
> continue;
>
> ?

Yes it makes the code easier to read.
Fixed in next iteration.

--
Thomas Richard, Bootlin
Embedded Linux and Kernel engineering