Re: [PATCH v2 08/15] phy: cadence-torrent: extract calls to clk_get from cdns_torrent_clk

Andy Shevchenko
2024-01-26T21:44:55Z

On Fri, Jan 26, 2024 at 4:37 PM Thomas Richard
<thomas.richard@bootlin.com> wrote:
>
> Extract calls to clk_get from cdns_torrent_clk into a separate function.
> It needs to call cdns_torrent_clk at resume without looking up the clock.
>
> Based on the work of Théo Lebrun <theo.lebrun@bootlin.com>

(Just a side question: Have you used --histogram diff algo when
preparing the series? Please use, if not)

...

> - cdns_phy->clk = devm_clk_get(dev, "refclk");
> + cdns_phy->clk = devm_clk_get(cdns_phy->dev, "refclk");
> if (IS_ERR(cdns_phy->clk)) {
> - dev_err(dev, "phy ref clock not found\n");
> + dev_err(cdns_phy->dev, "phy ref clock not found\n");
> return PTR_ERR(cdns_phy->clk);
> }

Same issue as I noted in a previous email.

--
With Best Regards,
Andy Shevchenko