Re: [PATCH v2 1/9] i2c: designware: Add some flexiblity to the model info

Jarkko Nikula
2024-02-09T14:14:41Z

On 2/6/24 17:30, Andy Shevchenko wrote:
> On Tue, Feb 06, 2024 at 04:51:50PM +0200, Jarkko Nikula wrote:
>> From: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
>>
>> Currently the way to identify a model is via a bit field, of which
>> 4 bits are currently defined.
>>
>> Use a shifted value to that more models can be defined.
>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> While this is true review, internally we're still discussing
> the possibility of moving to plain numbers and shift, so we
> may add arrays which are indexed in model-based way.
>
I was thinking I'll drop these first 3 patches in the next version and
go back to v1 version. IMHO it's better this patchset to focus
implementing generic polling only and not mix with cleaning up the
semaphore or other random stuff.

So planning to go back to v1 version and take your notes for v2 7/9 and
9/9. What would you think?