[PATCH v3 02/18] pinctrl: pinctrl-single: remove dead code in suspend() and resume() callbacks

Thomas Richard
2024-02-15T15:18:04Z

No need to check the pointer returned by platform_get_drvdata(), as
platform_set_drvdata() is called during the probe.

Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
drivers/pinctrl/pinctrl-single.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 19cc0db771a5..02eabd28d46e 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1693,11 +1693,7 @@ static void pcs_restore_context(struct pcs_device *pcs)
static int pinctrl_single_suspend(struct platform_device *pdev,
pm_message_t state)
{
- struct pcs_device *pcs;
-
- pcs = platform_get_drvdata(pdev);
- if (!pcs)
- return -EINVAL;
+ struct pcs_device *pcs = platform_get_drvdata(pdev);

if (pcs->flags & PCS_CONTEXT_LOSS_OFF) {
int ret;
@@ -1712,11 +1708,7 @@ static int pinctrl_single_suspend(struct platform_device *pdev,

static int pinctrl_single_resume(struct platform_device *pdev)
{
- struct pcs_device *pcs;
-
- pcs = platform_get_drvdata(pdev);
- if (!pcs)
- return -EINVAL;
+ struct pcs_device *pcs = platform_get_drvdata(pdev);

if (pcs->flags & PCS_CONTEXT_LOSS_OFF)
pcs_restore_context(pcs);

--
2.39.2