Re: [PATCH v3] eeprom: at24: fix memory corruption race condition

Markus Elfring
2024-04-20T09:11:32Z

> If the eeprom is not accessible, an nvmem device will be registered, the
> read will fail, and the device will be torn down.
…

Can it be nicer to present the introduction for failure conditions as an enumeration?

> Move the failure point before registering the nvmem device.
…

I would interpret the diff data more in the way that a devm_nvmem_register() call
should be performed a bit later in the implementation of the function “at24_probe”.
How do you think about to mention the affected function also in the summary phrase?

> ---
…

Please add a version description for your change approach.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc4#n713

Regards,
Markus