Re: [PATCH RFT] i2c: i801: Scan for Dell accelerometer i2c address

["Pali Rohár" <pali@kernel.org>]

On Friday 03 May 2024 16:09:03 Heiner Kallweit wrote:
> So far each new Dell device with an accelerometer requires a patch.
> All devices, with one older system as an exception, use address 0x29.
> So I think we can safely scan for the correct address

This is too risky. Poking random smbus address can lead to the lockup or
crash of the whole system. I really dislike such change which is going
to unconditionally on every system to scan or access fixed smbus address.
Crashing kernel on some new model in future or on some older models is
the worst user experience which can happen.

The hardcoded table with model name and address is the safest option to
prevent crashes or other unexpected behavior.

Instead, I would suggest to contact Dell if they can provide a way to
read accelerometer's i2c/smbus address from ACPI/WMI/DMI. And if there
is not any way right now then ask Dell to include it for new products.
So we can avoid having hardcoded table for new products released in
future.