Re: [PATCH] i2c: designware: Fix the functionality flags of the slave-only interface

[Jean Delvare <jdelvare@suse.de>]

On Fri, 31 May 2024 12:23:26 +0300, Andy Shevchenko wrote:
> On Fri, May 31, 2024 at 11:17:48AM +0200, Jean Delvare wrote:
> > When an I2C adapter acts only as a slave, it should not claim to
> > support I2C master capabilities.
> > 
> > Fixes: 5b6d721b266a ("i2c: designware: enable SLAVE in platform module")
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>  
> 
> The below can be separated by
> 
> ---
> 
> to avoid noise in the commit messages. The effect, namely Cc'ing to people,
> will stay the same.

Noted, I'll do that from now on.

> > Cc: Luis Oliveira <lolivei@synopsys.com>

BTW, the address above is no longer valid so it should be omitted when replying.

> > Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Cc: Jan Dabros <jsd@semihalf.com>
> > Cc: Andi Shyti <andi.shyti@kernel.org>
> > ---  
> 
> Other than that, LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks,
-- 
Jean Delvare
SUSE L3 Support