From: Guenter Roeck <linux@roeck-us.net>
To: linux-hwmon@vger.kernel.org
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"René Rebe" <rene@exactcode.de>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Armin Wolf" <W_Armin@gmx.de>,
"Stephen Horvath" <s.horvath@outlook.com.au>,
"Guenter Roeck" <linux@roeck-us.net>
Subject: [PATCH v4 3/6] hwmon: (spd5118) Add suspend/resume support
Date: Mon, 3 Jun 2024 21:02:34 -0700 [thread overview]
Message-ID: <20240604040237.1064024-4-linux@roeck-us.net> (raw)
In-Reply-To: <20240604040237.1064024-1-linux@roeck-us.net>
Add suspend/resume support to ensure that limit and configuration
registers are updated and synchronized after a suspend/resume cycle.
Cc: Armin Wolf <W_Armin@gmx.de>
Cc: Stephen Horvath <s.horvath@outlook.com.au>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v4: Fix bug seen if the enable attribute was never read prior
to a suspend/resume cycle.
v3: No change
v2: New patch
drivers/hwmon/spd5118.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c
index d3fc0ae17743..d55c073ff5fd 100644
--- a/drivers/hwmon/spd5118.c
+++ b/drivers/hwmon/spd5118.c
@@ -20,6 +20,7 @@
#include <linux/i2c.h>
#include <linux/hwmon.h>
#include <linux/module.h>
+#include <linux/pm.h>
#include <linux/regmap.h>
#include <linux/units.h>
@@ -432,6 +433,8 @@ static int spd5118_probe(struct i2c_client *client)
if (!spd5118_vendor_valid(bank, vendor))
return -ENODEV;
+ dev_set_drvdata(dev, regmap);
+
hwmon_dev = devm_hwmon_device_register_with_info(dev, "spd5118",
regmap, &spd5118_chip_info,
NULL);
@@ -449,6 +452,41 @@ static int spd5118_probe(struct i2c_client *client)
return 0;
}
+static int spd5118_suspend(struct device *dev)
+{
+ struct regmap *regmap = dev_get_drvdata(dev);
+ u32 regval;
+ int err;
+
+ /*
+ * Make sure the configuration register in the regmap cache is current
+ * before bypassing it.
+ */
+ err = regmap_read(regmap, SPD5118_REG_TEMP_CONFIG, ®val);
+ if (err < 0)
+ return err;
+
+ regcache_cache_bypass(regmap, true);
+ regmap_update_bits(regmap, SPD5118_REG_TEMP_CONFIG, SPD5118_TS_DISABLE,
+ SPD5118_TS_DISABLE);
+ regcache_cache_bypass(regmap, false);
+
+ regcache_cache_only(regmap, true);
+ regcache_mark_dirty(regmap);
+
+ return 0;
+}
+
+static int spd5118_resume(struct device *dev)
+{
+ struct regmap *regmap = dev_get_drvdata(dev);
+
+ regcache_cache_only(regmap, false);
+ return regcache_sync(regmap);
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(spd5118_pm_ops, spd5118_suspend, spd5118_resume);
+
static const struct i2c_device_id spd5118_id[] = {
{ "spd5118", 0 },
{ }
@@ -466,6 +504,7 @@ static struct i2c_driver spd5118_driver = {
.driver = {
.name = "spd5118",
.of_match_table = spd5118_of_ids,
+ .pm = pm_sleep_ptr(&spd5118_pm_ops),
},
.probe = spd5118_probe,
.id_table = spd5118_id,
--
2.39.2
next prev parent reply other threads:[~2024-06-04 4:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 4:02 [PATCH v4 0/6] hwmon: Add support for SPD5118 compliant chips Guenter Roeck
2024-06-04 4:02 ` [PATCH v4 1/6] dt-bindings: trivial-devices: Add jedec,spd5118 Guenter Roeck
2024-06-04 4:02 ` [PATCH v4 2/6] hwmon: Add support for SPD5118 compliant temperature sensors Guenter Roeck
2024-06-04 8:48 ` Stephen Horvath
2024-06-04 14:31 ` Guenter Roeck
2024-06-07 15:55 ` Armin Wolf
2024-06-04 4:02 ` Guenter Roeck [this message]
2024-06-04 8:45 ` [PATCH v4 3/6] hwmon: (spd5118) Add suspend/resume support Stephen Horvath
2024-06-04 14:31 ` Guenter Roeck
2024-06-07 15:57 ` Armin Wolf
2024-06-04 4:02 ` [PATCH v4 4/6] hwmon: (spd5118) Add support for reading SPD data Guenter Roeck
2024-06-04 11:58 ` Armin Wolf
2024-06-04 14:30 ` Guenter Roeck
2024-06-07 15:59 ` Armin Wolf
2024-06-04 4:02 ` [PATCH v4 5/6] i2c: smbus: Support DDR5 SPD EEPROMs Guenter Roeck
2024-06-04 7:32 ` Wolfram Sang
2024-06-05 12:21 ` Paul Menzel
2024-06-05 13:56 ` Guenter Roeck
2024-06-17 14:42 ` Paul Menzel
2024-06-17 15:49 ` Guenter Roeck
2024-06-18 10:25 ` Paul Menzel
2024-06-18 13:32 ` Guenter Roeck
2024-06-18 13:51 ` Paul Menzel
2024-06-18 14:23 ` Guenter Roeck
2024-06-18 14:59 ` Paul Menzel
2024-06-18 15:10 ` Guenter Roeck
2024-06-18 15:25 ` Paul Menzel
2024-06-18 15:43 ` Guenter Roeck
2024-06-18 18:16 ` Guenter Roeck
2024-06-18 18:59 ` Paul Menzel
2024-06-18 19:31 ` Guenter Roeck
2024-06-18 15:12 ` Guenter Roeck
2024-06-18 15:27 ` Paul Menzel
2024-06-07 16:06 ` Armin Wolf
2024-06-07 18:00 ` Wolfram Sang
2024-06-10 13:52 ` Guenter Roeck
2024-06-10 14:52 ` Wolfram Sang
2024-06-10 15:55 ` Guenter Roeck
2024-06-12 16:19 ` Wolfram Sang
2024-06-24 20:06 ` Heiner Kallweit
2024-06-24 20:30 ` Guenter Roeck
2024-06-04 4:02 ` [PATCH v4 6/6] hwmon: (spd5118) Add configuration option for auto-detection Guenter Roeck
2024-06-04 4:37 ` Thomas Weißschuh
2024-06-04 14:04 ` Guenter Roeck
2024-06-04 7:44 ` Wolfram Sang
2024-06-04 14:04 ` Guenter Roeck
2024-06-05 2:19 ` [PATCH v4a " Guenter Roeck
2024-06-05 9:22 ` Thomas Weißschuh
2024-06-05 14:04 ` Guenter Roeck
2024-06-07 16:08 ` Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604040237.1064024-4-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=rene@exactcode.de \
--cc=s.horvath@outlook.com.au \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).