From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: Peter Rosin <peda@axentia.se>, Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Korsgaard <peter.korsgaard@barco.com>,
Wolfram Sang <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Christopher Cordahi <christophercordahi@nanometrics.ca>,
Bastien Curutchet <bastien.curutchet@bootlin.com>
Subject: [PATCH v3 3/3] i2c: mux: gpio: Add support for the 'settle-time-us' property
Date: Mon, 17 Jun 2024 14:08:18 +0200 [thread overview]
Message-ID: <20240617120818.81237-4-bastien.curutchet@bootlin.com> (raw)
In-Reply-To: <20240617120818.81237-1-bastien.curutchet@bootlin.com>
Some hardware need some time to switch from a bus to another. This can
cause the first transfers following the selection of a bus to fail.
There is no way to configure this kind of waiting time in the driver.
Add support for the 'settle-time-us' device-tree property. When set,
the i2c_mux_gpio_select() applies a delay before returning, leaving
enough time to the hardware to switch to the new bus.
Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
---
drivers/i2c/muxes/i2c-mux-gpio.c | 6 ++++++
include/linux/platform_data/i2c-mux-gpio.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index c61e9d9ea695..944577bb09c1 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -6,6 +6,7 @@
*/
#include <linux/bits.h>
+#include <linux/delay.h>
#include <linux/gpio/consumer.h>
#include <linux/gpio/driver.h>
#include <linux/i2c.h>
@@ -37,6 +38,9 @@ static int i2c_mux_gpio_select(struct i2c_mux_core *muxc, u32 chan)
i2c_mux_gpio_set(mux, chan);
+ if (mux->data.settle_time)
+ fsleep(mux->data.settle_time);
+
return 0;
}
@@ -116,6 +120,8 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
if (device_property_read_u32(dev, "idle-state", &mux->data.idle))
mux->data.idle = I2C_MUX_GPIO_NO_IDLE;
+ device_property_read_u32(dev, "settle-time-us", &mux->data.settle_time);
+
return 0;
}
diff --git a/include/linux/platform_data/i2c-mux-gpio.h b/include/linux/platform_data/i2c-mux-gpio.h
index 816a4cd3ccb5..b548588aa1f2 100644
--- a/include/linux/platform_data/i2c-mux-gpio.h
+++ b/include/linux/platform_data/i2c-mux-gpio.h
@@ -19,6 +19,7 @@
* position
* @n_values: Number of multiplexer positions (busses to instantiate)
* @idle: Bitmask to write to MUX when idle or GPIO_I2CMUX_NO_IDLE if not used
+ * @settle_time: Delay to wait when a new bus is selected
*/
struct i2c_mux_gpio_platform_data {
int parent;
@@ -26,6 +27,7 @@ struct i2c_mux_gpio_platform_data {
const unsigned *values;
int n_values;
unsigned idle;
+ int settle_time;
};
#endif /* _LINUX_I2C_MUX_GPIO_H */
--
2.45.0
next prev parent reply other threads:[~2024-06-17 12:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 12:08 [PATCH v3 0/3] i2c: mux: gpio: Add 'settle-time-us' property Bastien Curutchet
2024-06-17 12:08 ` [PATCH v3 1/3] dt-bindings: i2c: " Bastien Curutchet
2024-06-17 12:19 ` Krzysztof Kozlowski
2024-07-09 21:42 ` Andi Shyti
2024-07-10 8:01 ` Peter Rosin
2024-07-12 7:00 ` Wolfram Sang
2024-06-17 12:08 ` [PATCH v3 2/3] i2c: mux: gpio: Re-order #include to match alphabetic order Bastien Curutchet
2024-07-09 21:42 ` Andi Shyti
2024-07-10 8:02 ` Peter Rosin
2024-06-17 12:08 ` Bastien Curutchet [this message]
2024-07-09 21:43 ` [PATCH v3 3/3] i2c: mux: gpio: Add support for the 'settle-time-us' property Andi Shyti
2024-07-10 8:02 ` Peter Rosin
2024-07-12 6:58 ` Wolfram Sang
2024-07-03 9:35 ` [PATCH v3 0/3] i2c: mux: gpio: Add " Bastien Curutchet
2024-07-09 21:45 ` Andi Shyti
2024-07-10 8:04 ` Peter Rosin
2024-07-16 18:28 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617120818.81237-4-bastien.curutchet@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=christophercordahi@nanometrics.ca \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).