RE: [PATCH 08/12] dt-bindings: i2c: renesas,riic: Document the R9A08G045 support

Biju Das
2024-06-21T12:56:45Z

Hi claudiu,

> -----Original Message-----
> From: claudiu beznea <claudiu.beznea@tuxon.dev>
> Sent: Friday, June 21, 2024 1:55 PM
> Subject: Re: [PATCH 08/12] dt-bindings: i2c: renesas,riic: Document the R9A08G045 support
>
>
>
> On 21.06.2024 15:34, Biju Das wrote:
> > Hi Claudiu,
> >
> >> -----Original Message-----
> >> From: Claudiu <claudiu.beznea@tuxon.dev>
> >> Sent: Friday, June 21, 2024 12:23 PM
> >> Subject: [PATCH 08/12] dt-bindings: i2c: renesas,riic: Document the
> >> R9A08G045 support
> >>
> >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >>
> >> Document the Renesas RZ/G3S (R9A08G045) RIIC IP. This is compatible
> >> with the version available on Renesas RZ/V2H (R9A09G075). Most of the
> >> IP variants that the RIIC driver is working with supports fast mode plus.
> >> However, it happens that on the same SoC to have IP instatiations
> >> that support fast mode plus as well as IP instantiation that doesn't
> >> support it. For this, introduced the renesas,riic-no-fast- mode-plus property.
> >>
> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >> ---
> >> Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> >> b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> >> index 91ecf17b7a81..c0964edbca69 100644
> >> --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> >> +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> >> @@ -25,6 +25,10 @@ properties:
> >> - renesas,riic-r9a07g054 # RZ/V2L
> >> - const: renesas,riic-rz # RZ/A or RZ/G2L
> >>
> >> + - items:
> >> + - const: renesas,riic-r9a08g045 # RZ/G3S
> >> + - const: renesas,riic-r9a09g057
> >> +
> >> - const: renesas,riic-r9a09g057 # RZ/V2H(P)
> >>
> >> reg:
> >> @@ -66,6 +70,10 @@ properties:
> >> resets:
> >> maxItems: 1
> >>
> >> + renesas,riic-no-fast-mode-plus:
> >> + description: specifies if fast mode plus is not supported
> >> + type: Boolean
> >
> > Can't this info, as part of device data?? Based on frequency and
> > device data is enough to derive this info??
>
> We can't rely completely on device data because on RZ/G3S we have 2 RIIC channels that support fast
> mode plus and 2 that doesn't support it.

Can't array of bits for this channels won't help??
Based on the bit info, you have that details and check against frequency defined in DT.

Cheers,
Biju