Re: [PATCH v4 0/6] i2c-i801 / dell-lis3lv02d: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d

Pali Rohár
2024-07-03T18:41:25Z

On Wednesday 03 July 2024 12:58:01 Hans de Goede wrote:
> Hi,
>
> On 6/24/24 8:28 PM, Pali Rohár wrote:
> > On Monday 24 June 2024 13:15:12 Hans de Goede wrote:
> >> Hans de Goede (6):
> >> i2c: core: Setup i2c_adapter runtime-pm before calling device_add()
> >> i2c: i801: Use a different adapter-name for IDF adapters
> >> platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to
> >> dell-smo8800-ids.h
> >> platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client
> >> from i2c-i801 to dell-lis3lv02d
> >> platform/x86: dell-smo8800: Add a couple more models to
> >> lis3lv02d_devices[]
> >> platform/x86: dell-smo8800: Add support for probing for the
> >> accelerometer i2c address
> >
> > Patches 1-5 looks good. There are just a few minor things, but you can add
> > Reviewed-by: Pali Rohár <pali@kernel.org>
>
> Thank you.
>
> > For patch 6 as I mentioned previously I'm strictly against this change
> > until somebody goes and politely ask Dell about the current situation of
> > the discovering of accelerometer's i2c address.
>
> Dell is on the Cc and not responding...

And what do you expecting here? That somebody on the group address
specified in CC list would react to all your tons of messages? Not
mentioning the fact that you did not even ask anything.

This is not how things works.

If you do not change your attitude here then I highly doubt that
somebody will respond to you.

I have feeling that you are doing it on purpose just because you do not
want to do anything, and trying to find some kind of proof that nobody
is responding to you, to convince others for merge your last hack change.

> > And if there is no other
> > option than start discussion if Dell can include this information into
> > DMI / ACPI / WMI or other part of firmware data which they can send from
> > BIOS/UEFI to operating system.
>
> AFAIK newer Dell laptops don't have a freefall sensor anymore since
> everything has moved to nvme. Even the bigger laptops seems to simply
> have multiple nvme slots rather then room for a 2.5" HDD. Note I did not
> research this, this is is my observation from 3 newer Dell laptops which
> I have access to.
>
> Regards,
>
> Hans
>
>
>
>
> >> drivers/i2c/busses/i2c-i801.c | 133 +-------
> >> drivers/i2c/i2c-core-base.c | 18 +-
> >> drivers/platform/x86/dell/Makefile | 1 +
> >> drivers/platform/x86/dell/dell-lis3lv02d.c | 331 +++++++++++++++++++
> >> drivers/platform/x86/dell/dell-smo8800-ids.h | 26 ++
> >> drivers/platform/x86/dell/dell-smo8800.c | 16 +-
> >> 6 files changed, 379 insertions(+), 146 deletions(-)
> >> create mode 100644 drivers/platform/x86/dell/dell-lis3lv02d.c
> >> create mode 100644 drivers/platform/x86/dell/dell-smo8800-ids.h
> >>
> >> --
> >> 2.45.1
> >>
> >
>