Re: [PATCH v3] dt-bindings: i2c: nxp,lpc1788-i2c: convert to dt schema

Krzysztof Kozlowski
2024-06-25T07:02:11Z

On 25/06/2024 08:59, Kanak Shilledar wrote:
> Convert the NXP I2C controller for LPC2xxx/178x/18xx/43xx
> to newer DT schema. Created DT schema based on the .txt file
> which had `compatible`, `reg`, `interrupts`, `clocks`,
> `#address-cells` and `#size-cells` as required properties.
>
> Additional changes to the original .txt binding
> - added maintainer from the MAINTAINERS file.
> - added resets property required by the corresponding DTS files.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Kanak Shilledar <kanakshilledar@gmail.com>
> ---
> Changes in v3:
> - removed "address-cells" and "size-cells" as per feedback.

you already sent v3 so this is rather v4. What happened here? Why are
you resending this?


This is a friendly reminder during the review process.

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.


Best regards,
Krzysztof