linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 05/60] i2c: bcm-kona: reword according to newest specification
Date: Sat,  6 Jul 2024 13:20:05 +0200	[thread overview]
Message-ID: <20240706112116.24543-6-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20240706112116.24543-1-wsa+renesas@sang-engineering.com>

Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2
specifications and replace "master/slave" with more appropriate terms.
Remove a useless comment while here.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 drivers/i2c/busses/i2c-bcm-kona.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b/drivers/i2c/busses/i2c-bcm-kona.c
index a57088ec2b06..eb5c46a8f824 100644
--- a/drivers/i2c/busses/i2c-bcm-kona.c
+++ b/drivers/i2c/busses/i2c-bcm-kona.c
@@ -85,7 +85,7 @@
 #define STD_EXT_CLK_FREQ		13000000UL
 #define HS_EXT_CLK_FREQ			104000000UL
 
-#define MASTERCODE			0x08 /* Mastercodes are 0000_1xxxb */
+#define CONTROLLER_CODE			0x08 /* Controller codes are 0000_1xxxb */
 
 #define I2C_TIMEOUT			100 /* msecs */
 
@@ -544,8 +544,8 @@ static int bcm_kona_i2c_switch_to_hs(struct bcm_kona_i2c_dev *dev)
 {
 	int rc;
 
-	/* Send mastercode at standard speed */
-	rc = bcm_kona_i2c_write_byte(dev, MASTERCODE, 1);
+	/* Send controller code at standard speed */
+	rc = bcm_kona_i2c_write_byte(dev, CONTROLLER_CODE, 1);
 	if (rc < 0) {
 		pr_err("High speed handshake failed\n");
 		return rc;
@@ -587,7 +587,6 @@ static int bcm_kona_i2c_switch_to_std(struct bcm_kona_i2c_dev *dev)
 	return rc;
 }
 
-/* Master transfer function */
 static int bcm_kona_i2c_xfer(struct i2c_adapter *adapter,
 			     struct i2c_msg msgs[], int num)
 {
@@ -637,7 +636,7 @@ static int bcm_kona_i2c_xfer(struct i2c_adapter *adapter,
 			}
 		}
 
-		/* Send slave address */
+		/* Send target address */
 		if (!(pmsg->flags & I2C_M_NOSTART)) {
 			rc = bcm_kona_i2c_do_addr(dev, pmsg);
 			if (rc < 0) {
@@ -697,7 +696,7 @@ static uint32_t bcm_kona_i2c_functionality(struct i2c_adapter *adap)
 }
 
 static const struct i2c_algorithm bcm_algo = {
-	.master_xfer = bcm_kona_i2c_xfer,
+	.xfer = bcm_kona_i2c_xfer,
 	.functionality = bcm_kona_i2c_functionality,
 };
 
@@ -722,7 +721,7 @@ static int bcm_kona_i2c_assign_bus_speed(struct bcm_kona_i2c_dev *dev)
 		dev->std_cfg = &std_cfg_table[BCM_SPD_1MHZ];
 		break;
 	case I2C_MAX_HIGH_SPEED_MODE_FREQ:
-		/* Send mastercode at 100k */
+		/* Send controller code at 100k */
 		dev->std_cfg = &std_cfg_table[BCM_SPD_100K];
 		dev->hs_cfg = &hs_cfg_table[BCM_SPD_3P4MHZ];
 		break;
-- 
2.43.0


  parent reply	other threads:[~2024-07-06 11:21 UTC|newest]

Thread overview: 136+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-06 11:20 [PATCH v2 00/60] i2c: reword first drivers according to newest specification Wolfram Sang
2024-07-06 11:20 ` [PATCH v2 01/60] i2c: reword i2c_algorithm " Wolfram Sang
2024-07-06 11:20 ` [PATCH v2 02/60] i2c: ali15x3: reword " Wolfram Sang
2024-07-06 11:20 ` [PATCH v2 03/60] i2c: altera: " Wolfram Sang
2024-07-06 11:20 ` [PATCH v2 04/60] i2c: au1550: " Wolfram Sang
2024-07-09 21:51   ` Andi Shyti
2024-07-06 11:20 ` Wolfram Sang [this message]
2024-07-06 11:20 ` [PATCH v2 06/60] i2c: bcm2835: " Wolfram Sang
2024-07-09 21:51   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 07/60] i2c: brcmstb: " Wolfram Sang
2024-07-06 11:20 ` [PATCH v2 08/60] i2c: cht-wc: " Wolfram Sang
2024-07-07 16:55   ` Hans de Goede
2024-07-06 11:20 ` [PATCH v2 09/60] i2c: cp2615: " Wolfram Sang
2024-07-06 15:07   ` Bence Csókás
2024-07-06 15:12     ` Wolfram Sang
2024-07-09 22:15       ` Andi Shyti
2024-07-10  6:41   ` [PATCH v3] " Wolfram Sang
2024-07-10 17:51     ` Bence Csókás
2024-07-06 11:20 ` [PATCH v2 10/60] i2c: cros-ec-tunnel: reword according to newest specification Wolfram Sang
2024-07-09 22:18   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 11/60] i2c: davinci: " Wolfram Sang
2024-07-10  8:04   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 12/60] i2c: digicolor: " Wolfram Sang
2024-07-10  8:05   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 13/60] i2c: diolan-u2c: " Wolfram Sang
2024-07-06 13:44   ` Guenter Roeck
2024-07-10  8:05   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 14/60] i2c: dln2: " Wolfram Sang
2024-07-06 11:20 ` [PATCH v2 15/60] i2c: fsi: " Wolfram Sang
2024-07-09 14:35   ` Eddie James
2024-07-10  8:08   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 16/60] i2c: gpio: " Wolfram Sang
2024-07-06 11:20 ` [PATCH v2 17/60] i2c: highlander: " Wolfram Sang
2024-07-10  8:08   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 18/60] i2c: hisi: " Wolfram Sang
2024-07-10  8:09   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 19/60] i2c: hix5hd2: " Wolfram Sang
2024-07-10  8:09   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 20/60] i2c: i801: " Wolfram Sang
2024-07-10  8:10   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 21/60] i2c: ibm_iic: " Wolfram Sang
2024-07-10 21:43   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 22/60] i2c: iop3xx: " Wolfram Sang
2024-07-10 21:44   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 23/60] i2c: isch: " Wolfram Sang
2024-07-10 21:45   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 24/60] i2c: jz4780: " Wolfram Sang
2024-07-08 11:20   ` Paul Cercueil
2024-07-10 21:45   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 25/60] i2c: kempld: " Wolfram Sang
2024-07-10 21:46   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 26/60] i2c: ljca: " Wolfram Sang
2024-07-10 21:49   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 27/60] i2c: lpc2k: " Wolfram Sang
2024-07-10 21:54   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 28/60] i2c: ls2x: " Wolfram Sang
2024-07-10 21:56   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 29/60] i2c: mlxcpld: " Wolfram Sang
2024-07-10 21:57   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 30/60] i2c: mpc: " Wolfram Sang
2024-07-07 20:52   ` Chris Packham
2024-07-10 21:58   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 31/60] i2c: mt7621: " Wolfram Sang
2024-07-10 21:59   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 32/60] i2c: mv64xxx: " Wolfram Sang
2024-07-10 22:11   ` Andi Shyti
2024-07-10 22:21     ` Wolfram Sang
2024-07-11  8:05       ` Andi Shyti
2024-07-16  8:38     ` Gregory CLEMENT
2024-07-16  8:57       ` Wolfram Sang
2024-07-11 10:21   ` Andi Shyti
2024-07-16  8:41     ` Gregory CLEMENT
2024-07-06 11:20 ` [PATCH v2 33/60] i2c: ocores: " Wolfram Sang
2024-07-11  8:01   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 34/60] i2c: octeon: " Wolfram Sang
2024-07-11  8:02   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 35/60] i2c: opal: " Wolfram Sang
2024-07-11  8:06   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 36/60] i2c: owl: " Wolfram Sang
2024-07-11  8:06   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 37/60] i2c: pasemi: " Wolfram Sang
2024-07-07 10:50   ` Sven Peter
2024-07-11  8:07   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 38/60] i2c: piix4: " Wolfram Sang
2024-07-11  8:09   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 39/60] i2c: powermac: " Wolfram Sang
2024-07-11  8:10   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 40/60] i2c: pxa-pci: " Wolfram Sang
2024-07-11  8:10   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 41/60] i2c: riic: " Wolfram Sang
2024-07-11 10:21   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 42/60] i2c: rk3x: " Wolfram Sang
2024-07-11 10:22   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 43/60] i2c: robotfuzz-osif: " Wolfram Sang
2024-07-11 10:23   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 44/60] i2c: rzv2m: " Wolfram Sang
2024-07-11 10:23   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 45/60] i2c: sis5595: " Wolfram Sang
2024-07-11 10:24   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 46/60] i2c: sprd: " Wolfram Sang
2024-07-11 10:25   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 47/60] i2c: stm32f4: " Wolfram Sang
2024-07-09 11:32   ` Alain Volmat
2024-07-09 11:38     ` Pierre Yves MORDRET
2024-07-11 10:25   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 48/60] i2c: sun6i-p2wi: " Wolfram Sang
2024-07-06 11:43   ` Chen-Yu Tsai
2024-07-11 10:26   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 49/60] i2c: taos-evm: " Wolfram Sang
2024-07-11 10:27   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 50/60] i2c: tegra-bpmp: " Wolfram Sang
2024-07-11 10:27   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 51/60] i2c: thunderx-pcidrv: " Wolfram Sang
2024-07-11 12:44   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 52/60] i2c: tiny-usb: " Wolfram Sang
2024-07-11 12:58   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 53/60] i2c: uniphier-f: " Wolfram Sang
2024-07-11 12:59   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 54/60] i2c: uniphier: " Wolfram Sang
2024-07-11 13:00   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 55/60] i2c: viperboard: " Wolfram Sang
2024-07-11 13:02   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 56/60] i2c: viai2c: " Wolfram Sang
2024-07-11 13:05   ` Andi Shyti
2024-07-11 14:44     ` Wolfram Sang
2024-07-06 11:20 ` [PATCH v2 57/60] i2c: nvidia-gpu: " Wolfram Sang
2024-07-11 13:05   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 58/60] i2c: virtio: " Wolfram Sang
2024-07-08  5:53   ` Viresh Kumar
2024-07-11 13:06   ` Andi Shyti
2024-07-06 11:20 ` [PATCH v2 59/60] i2c: cpm: " Wolfram Sang
2024-07-06 11:21 ` [PATCH v2 60/60] i2c: st: " Wolfram Sang
2024-07-09 10:21   ` Alain Volmat
2024-07-11 13:07   ` Andi Shyti
2024-07-11 13:16 ` [PATCH v2 00/60] i2c: reword first drivers " Andi Shyti
2024-07-11 14:45   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240706112116.24543-6-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andi.shyti@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).