Re: [PATCH v4 3/6] drm/i915: Make I2C terminology more inclusive

Andi Shyti
2024-07-22T16:28:47Z

Hi Easwar,

On Mon, Jul 22, 2024 at 09:15:08AM -0700, Easwar Hariharan wrote:
> On 7/22/2024 5:50 AM, Andi Shyti wrote:
> > Hi Easwar,
> >
> > merged to drm-intel-next. Thanks!
> >
> > On Thu, Jul 11, 2024 at 05:27:31AM +0000, Easwar Hariharan wrote:
> >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave"
> >> with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/,
> >> fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that
> >> the approved verbiage exists in the specification.
> >>
> >> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >
> > I realized after pushing that this had the tag:
> >
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >
> > Not a big deal, but it's still a minor mistake.
> >
> > Andi
>
> Thank you for the merge, Andi! I'm missing what the mistake is, I added
> the tags as I got them. Was I supposed to drop the R-B when Rodrigo gave
> an A-B?

Sorry, it's not yours, it's mine. I should have checked more
carefully the tag section before pushing. You did everything
right.

The dim tool (drm maintianers tool) picked up all the tags added
and I missed the double tag.

This was more a message for Rodrigo, in case he wanted to fix it,
but I guess no one will complain about.

Thanks a lot for your work and effort!
Andi