Re: [PATCH v7 6/6] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address

Hans de Goede
2024-08-12T20:30:15Z

Hi,

On 8/5/24 10:51 PM, Andy Shevchenko wrote:
> On Mon, Aug 5, 2024 at 3:39 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Unfortunately the SMOxxxx ACPI device does not contain the i2c-address
>> of the accelerometer. So a DMI product-name to address mapping table
>> is used.
>>
>> At support to have the kernel probe for the i2c-address for modesl
>
> models
>
>> which are not on the list.
>>
>> The new probing code sits behind a new probe_i2c_addr module parameter,
>> which is disabled by default because probing might be dangerous.
>
> ...
>
>> +static int detect_lis3lv02d(struct i2c_adapter *adap, unsigned short addr)
>> +{
>> + union i2c_smbus_data smbus_data;
>> + int err;
>> +
>> + pr_info("Probing for lis3lv02d on address 0x%02x\n", addr);
>
> Using dev_info() against an adapter device might be more useful, no?

Ack, good idea, added for v8.

Regards,

Hans