Re: [PATCH v3 1/5] dt-bindings: i2c: qcom-cci: Document SDM670 compatible

Vladimir Zapolskiy
2024-08-20T08:40:27Z

On 8/20/24 01:10, Richard Acayan wrote:
> The CCI on the Snapdragon 670 is the interface for controlling camera
> hardware over I2C. Add the compatible so it can be added to the SDM670
> device tree.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index c33ae7b63b84..af6dd9a34fd4 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -27,6 +27,7 @@ properties:
> - enum:
> - qcom,sc7280-cci
> - qcom,sc8280xp-cci
> + - qcom,sdm670-cci
> - qcom,sdm845-cci
> - qcom,sm6350-cci
> - qcom,sm8250-cci
> @@ -138,6 +139,23 @@ allOf:
> - const: cci
> - const: camss_ahb
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sdm670-cci
> + then:
> + properties:
> + clocks:
> + minItems: 4
> + clock-names:
> + items:
> + - const: camnoc_axi
> + - const: soc_ahb
> + - const: cpas_ahb
> + - const: cci
> +
> - if:
> properties:
> compatible:

After fixing a review comment by Krzysztof,

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

--
Best wishes,
Vladimir