From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
Narasimhan.V@amd.com, Borislav Petkov <bp@alien8.de>,
Kim Phillips <kim.phillips@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v1 3/5] i2c: designware: Unify the firmware type checks
Date: Thu, 22 Aug 2024 20:58:39 +0300 [thread overview]
Message-ID: <20240822180411.2298991-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240822180411.2298991-1-andriy.shevchenko@linux.intel.com>
Instead of asymmetrical checks for the firmware type use
the is_*_node() calls.
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/i2c-designware-common.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c
index b0d3c47d93ce..2c460093b7ab 100644
--- a/drivers/i2c/busses/i2c-designware-common.c
+++ b/drivers/i2c/busses/i2c-designware-common.c
@@ -22,6 +22,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/pm_runtime.h>
+#include <linux/property.h>
#include <linux/regmap.h>
#include <linux/swab.h>
#include <linux/types.h>
@@ -372,14 +373,15 @@ int i2c_dw_fw_parse_and_configure(struct dw_i2c_dev *dev)
{
struct i2c_timings *t = &dev->timings;
struct device *device = dev->dev;
+ struct fwnode_handle *fwnode = dev_fwnode(device);
i2c_parse_fw_timings(device, t, false);
i2c_dw_adjust_bus_speed(dev);
- if (device->of_node)
+ if (is_of_node(fwnode))
i2c_dw_of_configure(device);
- if (has_acpi_companion(device))
+ else if (is_acpi_node(fwnode))
i2c_dw_acpi_configure(device);
return i2c_dw_validate_speed(dev);
--
2.43.0.rc1.1336.g36b5255a03ac
next prev parent reply other threads:[~2024-08-22 18:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 17:58 [PATCH v1 0/5] i2c: designware: Cleanups (part 2) Andy Shevchenko
2024-08-22 17:58 ` [PATCH v1 1/5] i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure() Andy Shevchenko
2024-08-22 17:58 ` [PATCH v1 2/5] i2c: designware: Consolidate firmware parsing and configuring code Andy Shevchenko
2024-08-22 17:58 ` Andy Shevchenko [this message]
2024-08-22 17:58 ` [PATCH v1 4/5] i2c: designware: Move exports to I2C_DW namespaces Andy Shevchenko
2024-08-22 17:58 ` [PATCH v1 5/5] i2c: designware: Remove ->disable() callback Andy Shevchenko
2024-08-23 0:45 ` [PATCH v1 0/5] i2c: designware: Cleanups (part 2) Andi Shyti
2024-08-23 13:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822180411.2298991-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Narasimhan.V@amd.com \
--cc=andi.shyti@kernel.org \
--cc=bp@alien8.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=kim.phillips@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox