Re: [PATCH v2 3/5] i2c: piix4: Add ACPI support for ASF SMBus device

[kernel test robot <lkp@intel.com>]

Hi Shyam,

kernel test robot noticed the following build errors:

[auto build test ERROR on andi-shyti/i2c/i2c-host]
[also build test ERROR on linus/master v6.11-rc6 next-20240904]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shyam-Sundar-S-K/i2c-piix4-Allow-more-than-two-algo-selection-for-SMBus/20240904-190034
base:   https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
patch link:    https://lore.kernel.org/r/20240904105731.2246235-4-Shyam-sundar.S-k%40amd.com
patch subject: [PATCH v2 3/5] i2c: piix4: Add ACPI support for ASF SMBus device
config: arm-randconfig-003-20240905 (https://download.01.org/0day-ci/archive/20240905/202409051719.oja4MkJZ-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 05f5a91d00b02f4369f46d076411c700755ae041)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240905/202409051719.oja4MkJZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409051719.oja4MkJZ-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/i2c/busses/i2c-piix4.c:26:
   In file included from include/linux/pci.h:1646:
   In file included from include/linux/dmapool.h:14:
   In file included from include/linux/scatterlist.h:8:
   In file included from include/linux/mm.h:2228:
   include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     517 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> drivers/i2c/busses/i2c-piix4.c:1318:9: error: call to undeclared function 'acpi_fetch_acpi_dev'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1318 |         adev = acpi_fetch_acpi_dev(handle);
         |                ^
   drivers/i2c/busses/i2c-piix4.c:1318:9: note: did you mean 'acpi_match_acpi_device'?
   include/linux/acpi.h:932:44: note: 'acpi_match_acpi_device' declared here
     932 | static inline const struct acpi_device_id *acpi_match_acpi_device(
         |                                            ^
>> drivers/i2c/busses/i2c-piix4.c:1318:7: error: incompatible integer to pointer conversion assigning to 'struct acpi_device *' from 'int' [-Wint-conversion]
    1318 |         adev = acpi_fetch_acpi_dev(handle);
         |              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-piix4.c:1322:8: error: call to undeclared function 'acpi_dev_get_resources'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1322 |         ret = acpi_dev_get_resources(adev, &res_list, sb800_asf_acpi_resource_cb, &data);
         |               ^
   drivers/i2c/busses/i2c-piix4.c:1322:8: note: did you mean 'acpi_get_event_resources'?
   include/acpi/acpixf.h:809:9: note: 'acpi_get_event_resources' declared here
     809 |                              acpi_get_event_resources(acpi_handle device_handle,
         |                              ^
   include/acpi/platform/aclinux.h:93:21: note: expanded from macro 'ACPI_EXTERNAL_RETURN_STATUS'
      93 |         static ACPI_INLINE prototype {return(AE_NOT_CONFIGURED);}
         |                            ^
>> drivers/i2c/busses/i2c-piix4.c:1328:2: error: call to undeclared function 'acpi_dev_free_resource_list'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1328 |         acpi_dev_free_resource_list(&res_list);
         |         ^
   drivers/i2c/busses/i2c-piix4.c:1328:2: note: did you mean 'pci_free_resource_list'?
   include/linux/pci.h:1496:6: note: 'pci_free_resource_list' declared here
    1496 | void pci_free_resource_list(struct list_head *resources);
         |      ^
   1 warning and 4 errors generated.


vim +/acpi_fetch_acpi_dev +1318 drivers/i2c/busses/i2c-piix4.c

  1303	
  1304	static int sb800_asf_add_adap(struct pci_dev *dev)
  1305	{
  1306		struct i2c_piix4_adapdata *adapdata;
  1307		struct sb800_asf_data data;
  1308		struct acpi_device *adev;
  1309		LIST_HEAD(res_list);
  1310		acpi_status status;
  1311		acpi_handle handle;
  1312		int ret;
  1313	
  1314		status = acpi_get_handle(NULL, SB800_ASF_ACPI_PATH, &handle);
  1315		if (ACPI_FAILURE(status))
  1316			return -ENODEV;
  1317	
> 1318		adev = acpi_fetch_acpi_dev(handle);
  1319		if (!adev)
  1320			return -ENODEV;
  1321	
> 1322		ret = acpi_dev_get_resources(adev, &res_list, sb800_asf_acpi_resource_cb, &data);
  1323		if (ret < 0) {
  1324			dev_err(&dev->dev, "Error getting ASF ACPI resource: %d\n", ret);
  1325			return ret;
  1326		}
  1327	
> 1328		acpi_dev_free_resource_list(&res_list);
  1329		ret = piix4_add_adapter(dev, data.addr, SMBUS_ASF, piix4_adapter_count, false, 0,
  1330					piix4_main_port_names_sb800[piix4_adapter_count],
  1331					&piix4_main_adapters[piix4_adapter_count]);
  1332		if (ret) {
  1333			dev_err(&dev->dev, "Failed to add ASF adapter: %d\n", ret);
  1334			return -ENODEV;
  1335		}
  1336	
  1337		adapdata = i2c_get_adapdata(piix4_main_adapters[piix4_adapter_count]);
  1338		ret = devm_request_irq(&dev->dev, data.irq, sb800_asf_irq_handler, IRQF_SHARED,
  1339				       "sb800_smbus_asf", adapdata);
  1340		if (ret) {
  1341			dev_err(&dev->dev, "Unable to request irq: %d for use\n", data.irq);
  1342			return ret;
  1343		}
  1344	
  1345		INIT_DELAYED_WORK(&adapdata->work_buf, sb800_asf_process_slave);
  1346		adapdata->is_asf = true;
  1347		/* Increment the adapter count by 1 as ASF is added to the list */
  1348		piix4_adapter_count += 1;
  1349		return 1;
  1350	}
  1351	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki