Re: [PATCH v1 0/5] i2c: designware: Cleanups (part 4)

Jarkko Nikula
2024-09-25T13:37:32Z

On 9/25/24 3:44 PM, Andy Shevchenko wrote:
> This is the subset of the patches [1] that should not affect any
> functionality. Here are:
> - tiding up the probe and remove functions
> - dead and redundant code removal
> - spelling fixes
>
> In any case this is Cc'ed to AMD who reported a problem in [1]
> presumably in the patch that is *not* included here.
>
> Link: https://lore.kernel.org/linux-i2c/20231207141653.2785124-1-andriy.shevchenko@linux.intel.com/ [1]
>
> This is assumed to be the last straightforward patch series to clean up
> the driver. The rest is directly related or dependent on the reported
> problem and needs more thinking and work. Perhaps I can do it in the
> future.
>
> Andy Shevchenko (5):
> i2c: designware: Use temporary variable for struct device
> i2c: designware: Get rid of redundant 'else'
> i2c: designware: Remove 'cond' from i2c_dw_scl_hcnt()
> i2c: designware: Use sda_hold_time variable name everywhere
> i2c: designware: Fix spelling and other issues in the comments
>
> drivers/i2c/busses/i2c-designware-amdpsp.c | 10 ++--
> drivers/i2c/busses/i2c-designware-common.c | 66 +++++++--------------
> drivers/i2c/busses/i2c-designware-core.h | 12 ++--
> drivers/i2c/busses/i2c-designware-master.c | 17 +++---
> drivers/i2c/busses/i2c-designware-pcidrv.c | 39 ++++++------
> drivers/i2c/busses/i2c-designware-platdrv.c | 52 ++++++++--------
> drivers/i2c/busses/i2c-designware-slave.c | 6 +-
> 7 files changed, 90 insertions(+), 112 deletions(-)
>
To all:

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>