linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, lee@kernel.org, sre@kernel.org,
	tsbogend@alpha.franken.de
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-mips@vger.kernel.org,
	Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v5 1/6] dt-bindings: reset: syscon-reboot: Add reg property
Date: Thu, 26 Sep 2024 09:58:42 +1200	[thread overview]
Message-ID: <20240925215847.3594898-2-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20240925215847.3594898-1-chris.packham@alliedtelesis.co.nz>

The syscon-reboot binding used 'offset' for historical reasons. Having a
reg property is appropriate when these nodes are children of a MMIO bus.
Add a reg property and modify the constraints so that one of 'reg' or
'offset' is expected.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---

Notes:
    Changes in v5:
    - New, suggested by Krzysztof

 .../bindings/power/reset/syscon-reboot.yaml           | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
index 75061124d9a8..19d3093e6cd2 100644
--- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
+++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
@@ -31,6 +31,10 @@ properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: Offset in the register map for the reboot register (in bytes).
 
+  reg:
+    maxItems: 1
+    description: Base address and size for the reboot register.
+
   regmap:
     $ref: /schemas/types.yaml#/definitions/phandle
     deprecated: true
@@ -45,9 +49,14 @@ properties:
   priority:
     default: 192
 
+oneOf:
+  - required:
+      - offset
+  - required:
+      - reg
+
 required:
   - compatible
-  - offset
 
 additionalProperties: false
 
-- 
2.46.2


  reply	other threads:[~2024-09-25 22:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25 21:58 [PATCH v5 0/6] RTL9300 support for reboot and i2c Chris Packham
2024-09-25 21:58 ` Chris Packham [this message]
2024-09-26  6:34   ` [PATCH v5 1/6] dt-bindings: reset: syscon-reboot: Add reg property Krzysztof Kozlowski
2024-09-25 21:58 ` [PATCH v5 2/6] power: reset: syscon-reboot: Accept " Chris Packham
2024-09-26  6:35   ` Krzysztof Kozlowski
2024-09-25 21:58 ` [PATCH v5 3/6] dt-bindings: mfd: Add Realtek RTL9300 switch peripherals Chris Packham
2024-09-26  6:36   ` Krzysztof Kozlowski
2024-09-26  7:45     ` Lee Jones
2024-09-26  7:47       ` Krzysztof Kozlowski
2024-09-25 21:58 ` [PATCH v5 4/6] mips: dts: realtek: Add syscon-reboot node Chris Packham
2024-09-26  6:36   ` Krzysztof Kozlowski
2024-09-25 21:58 ` [PATCH v5 5/6] mips: dts: realtek: Add I2C controllers Chris Packham
2024-09-26  6:37   ` Krzysztof Kozlowski
2024-09-26 20:52     ` Chris Packham
2024-09-26 20:58   ` [PATCH v5] fixup! i2c: Add driver for the RTL9300 I2C controller Chris Packham
2024-09-25 21:58 ` [PATCH v5 6/6] " Chris Packham
2024-09-29  2:41   ` kernel test robot
2024-09-29  8:45   ` Markus Elfring
2024-09-29 20:17     ` Chris Packham
2024-09-30  7:55       ` Markus Elfring
2024-09-30  8:12         ` Javier Carrasco
2024-09-29 20:09   ` [PATCH] fixup! " Chris Packham
2024-10-02 10:57     ` Andi Shyti
2024-10-14  0:48       ` Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240925215847.3594898-2-chris.packham@alliedtelesis.co.nz \
    --to=chris.packham@alliedtelesis.co.nz \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).