From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@kernel.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v2] i2c: Drop legacy muxing pseudo-drivers
Date: Tue, 15 Oct 2024 13:40:41 +0200 [thread overview]
Message-ID: <20241015134041.4b7ddb6f@endymion.delvare> (raw)
In-Reply-To: <ZRZ9v3GTLcH3kBnw@ninjato>
Hi Wolfram,
On Fri, 29 Sep 2023 09:33:19 +0200, Wolfram Sang wrote:
> On Thu, Sep 28, 2023 at 10:16:55AM +0200, Jean Delvare wrote:
> > The i2c-amd756-s4882 and i2c-nforce2-s4985 muxing pseudo-drivers were
> > written at a time when the i2c core did not support muxing. They are
> > essentially board-specific hacks. If we had to add support for these
> > boards today, we would implement it in a completely different way.
> >
> > These Tyan server boards are 18 years old by now, so I very much doubt
> > any of these is still running today. So let's just drop this clumsy
> > code. If anyone really still needs this support and complains, I'll
> > rewrite it in a proper way on top of i2c-mux.
> >
> > This also fixes the following warnings:
> > drivers/i2c/busses/i2c-amd756.c:286:20: warning: symbol 'amd756_smbus' was not declared. Should it be static?
> > drivers/i2c/busses/i2c-nforce2.c:123:20: warning: symbol 'nforce2_smbus' was not declared. Should it be static?
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Acked-by: Nick Desaulniers <ndesaulniers@google.com>
> > Cc: Andi Shyti <andi.shyti@kernel.org>
>
> Applied to for-next, thanks!
What happened to this patch? This was one year ago but I can't find it
upstream. Should I resend it?
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2024-10-15 11:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 8:16 [PATCH v2] i2c: Drop legacy muxing pseudo-drivers Jean Delvare
2023-09-28 15:03 ` Andi Shyti
2023-09-28 15:09 ` Wolfram Sang
2023-09-28 16:47 ` Wolfram Sang
2023-09-28 20:26 ` Andi Shyti
2023-09-28 20:34 ` Nick Desaulniers
2023-09-28 15:34 ` Nick Desaulniers
2023-09-28 16:49 ` Wolfram Sang
2023-09-28 16:52 ` Nick Desaulniers
2023-09-28 20:56 ` Andi Shyti
2023-09-29 7:33 ` Wolfram Sang
2024-10-15 11:40 ` Jean Delvare [this message]
2024-10-16 15:19 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015134041.4b7ddb6f@endymion.delvare \
--to=jdelvare@suse.de \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).