Re: [PATCH v2 1/1] i2c: busses: Use *-y instead of *-objs in Makefile

Andi Shyti
2024-11-05T14:44:38Z

Hi Andy,

On Mon, Nov 04, 2024 at 12:39:14PM +0200, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
>
> Let's correct the old usages of *-objs in Makefiles.

...

> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index bf79628a789d..20a8c88e854a 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -431,7 +431,7 @@ config I2C_AT91
> are facing this situation, use the i2c-gpio driver.
>
> config I2C_AT91_SLAVE_EXPERIMENTAL
> - tristate "Microchip AT91 I2C experimental slave mode"
> + bool "Microchip AT91 I2C experimental slave mode"
> depends on I2C_AT91
> select I2C_SLAVE
> help
> @@ -440,7 +440,7 @@ config I2C_AT91_SLAVE_EXPERIMENTAL
> been tested in a heavy way, help wanted.
> There are known bugs:
> - It can hang, on a SAMA5D4, after several transfers.
> - - There are some mismtaches with a SAMA5D4 as slave and a SAMA5D2 as
> + - There are some mismatches with a SAMA5D4 as slave and a SAMA5D2 as

Although these changes are related and I'm OK also with the typo
fix, could you please propose here a couple of lines that I can
add to the commit message?

Thanks,
Andi