From: Jiasheng Jiang <jiashengjiangcool@gmail.com>
To: andi.shyti@kernel.org
Cc: rmk@dyn-67.arm.linux.org.uk, max.schwarz@online.de,
dianders@chromium.org, david.wu@rock-chips.com, heiko@sntech.de,
vz@mleia.com, wsa@kernel.org, manabian@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: [PATCH v2 1/3] i2c: lpc2k: Add check for clk_enable()
Date: Tue, 5 Nov 2024 16:18:18 +0000 [thread overview]
Message-ID: <20241105161820.32512-1-jiashengjiangcool@gmail.com> (raw)
Add check for the return value of clk_enable() in order to catch the
potential exception.
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
Changelog:
v1 -> v2:
1. Remove the Fixes tag.
2. Use dev_err_probe to simplify error handling.
---
drivers/i2c/busses/i2c-lpc2k.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-lpc2k.c b/drivers/i2c/busses/i2c-lpc2k.c
index 9fb33cbf7419..0fe7d4421a31 100644
--- a/drivers/i2c/busses/i2c-lpc2k.c
+++ b/drivers/i2c/busses/i2c-lpc2k.c
@@ -442,8 +442,12 @@ static int i2c_lpc2k_suspend(struct device *dev)
static int i2c_lpc2k_resume(struct device *dev)
{
struct lpc2k_i2c *i2c = dev_get_drvdata(dev);
+ int ret;
+
+ ret = clk_enable(i2c->clk);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to enable clock: %d\n", ret);
- clk_enable(i2c->clk);
i2c_lpc2k_reset(i2c);
return 0;
--
2.25.1
next reply other threads:[~2024-11-05 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 16:18 Jiasheng Jiang [this message]
2024-11-05 16:18 ` [PATCH v2 2/3] i2c: pxa: Add check for clk_enable() and clk_prepare_enable() Jiasheng Jiang
2024-11-05 16:18 ` [PATCH v2 3/3] i2c: rk3x: Add check for clk_enable() Jiasheng Jiang
2024-11-05 21:29 ` Doug Anderson
2024-11-06 23:01 ` Andi Shyti
2024-11-08 2:27 ` Jiasheng Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105161820.32512-1-jiashengjiangcool@gmail.com \
--to=jiashengjiangcool@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=david.wu@rock-chips.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=manabian@gmail.com \
--cc=max.schwarz@online.de \
--cc=rmk@dyn-67.arm.linux.org.uk \
--cc=vz@mleia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox