Re: [PATCH v2 1/2] dt-bindings: trivial-devices: add ltp8800

Conor Dooley
2024-11-06T16:06:08Z

[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]

On Tue, Nov 05, 2024 at 08:34:01PM -0800, Guenter Roeck wrote:
> On 11/5/24 19:09, Cedric Encarnacion wrote:
> > Add Analog Devices LTP8800-1A, LTP8800-2, and LTP8800-4A DC/DC μModule
> > regulator.

A single compatible for 3 devices is highly suspect. What is
different between these devices?

> >
> > Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
> > ---
> > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > MAINTAINERS | 5 +++++
> > 2 files changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 90a7c0a3dc48..72877d00b8dd 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -43,6 +43,8 @@ properties:
> > - adi,adp5589
> > # Analog Devices LT7182S Dual Channel 6A, 20V PolyPhase Step-Down Silent Switcher
> > - adi,lt7182s
> > + # Analog Devices LTP8800-1A/-2/-4A 150A/135A/200A, 54V DC/DC μModule regulator
> > + - adi,ltp8800
> > # AMS iAQ-Core VOC Sensor
> > - ams,iaq-core
> > # Temperature monitoring of Astera Labs PT5161L PCIe retimer
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 7c357800519a..6ca691500fb7 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -13555,6 +13555,11 @@ S: Maintained
> > F: Documentation/devicetree/bindings/iio/light/liteon,ltr390.yaml
> > F: drivers/iio/light/ltr390.c
> > +LTP8800 HARDWARE MONITOR DRIVER
> > +M: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
> > +L: linux-hwmon@vger.kernel.org
> > +S: Supported
> > +
>
> This entry doesn't make sense in this patch.
>
> Guenter
>
> > LYNX 28G SERDES PHY DRIVER
> > M: Ioana Ciornei <ioana.ciornei@nxp.com>
> > L: netdev@vger.kernel.org
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]