Re: [PATCH v1 4/7] soc: qcom: geni-se:: Add support to load QUP SE Firmware via Linux subsystem

kernel test robot
2024-12-04T21:23:46Z

Hi Viken,

kernel test robot noticed the following build errors:

[auto build test ERROR on andi-shyti/i2c/i2c-host]
[also build test ERROR on tty/tty-testing tty/tty-next tty/tty-linus broonie-spi/for-next linus/master v6.13-rc1 next-20241204]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Viken-Dadhaniya/dt-bindings-i2c-qcom-i2c-geni-Document-DT-properties-for-QUP-firmware-loading/20241204-230736
base: https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
patch link: https://lore.kernel.org/r/20241204150326.1470749-5-quic_vdadhani%40quicinc.com
patch subject: [PATCH v1 4/7] soc: qcom: geni-se:: Add support to load QUP SE Firmware via Linux subsystem
config: x86_64-buildonly-randconfig-003-20241205 (https://download.01.org/0day-ci/archive/20241205/202412050408.rTlLBe7e-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241205/202412050408.rTlLBe7e-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412050408.rTlLBe7e-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

In file included from drivers/soc/qcom/qcom-geni-se.c:11:
In file included from include/linux/dma-mapping.h:8:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/soc/qcom/qcom-geni-se.c:975:9: error: assigning to 'struct elf32_phdr *' from 'const struct elf32_phdr *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
975 | *phdr = &phdrs[i];
| ^ ~~~~~~~~~
>> drivers/soc/qcom/qcom-geni-se.c:1182:2: warning: variable 'reg_value' is uninitialized when used here [-Wuninitialized]
1182 | reg_value |= DMA_GENERAL_CFG_AHB_SEC_SLV_CLK_CGC_ON_BMSK |
| ^~~~~~~~~
drivers/soc/qcom/qcom-geni-se.c:1136:18: note: initialize the variable 'reg_value' to silence this warning
1136 | u32 i, reg_value, mask, ramn_cnt;
| ^
| = 0
drivers/soc/qcom/qcom-geni-se.c:1268:5: warning: no previous prototype for function 'qup_fw_load' [-Wmissing-prototypes]
1268 | int qup_fw_load(struct qup_se_rsc *rsc)
| ^
drivers/soc/qcom/qcom-geni-se.c:1268:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
1268 | int qup_fw_load(struct qup_se_rsc *rsc)
| ^
| static
3 warnings and 1 error generated.

vim +975 drivers/soc/qcom/qcom-geni-se.c

946
947 /**
948 * read_elf: Function to read elf file.
949 * @rsc: A pointer to SE resources structure.
950 * @fw: A pointer to the fw buffer.
951 * @pelfseg: A pointer to SE specific elf header.
952 * @phdr: pointer to one of the valid headers from list from fw buffer.
953 *
954 * This function reads the ELF file and outputs the pointer to header
955 * data which contains the FW data and any other details.
956 *
957 * return: Return 0 if no error, else return error value.
958 */
959 static int read_elf(struct qup_se_rsc *rsc, const struct firmware *fw,
960 struct elf_se_hdr **pelfseg, struct elf32_phdr **phdr)
961 {
962 const struct elf32_phdr *phdrs;
963 const struct elf32_hdr *ehdr;
964 const u8 *addr;
965 int i;
966
967 ehdr = (struct elf32_hdr *)fw->data;
968
969 if (ehdr->e_phnum < 2)
970 return -EINVAL;
971
972 phdrs = (struct elf32_phdr *)(ehdr + 1);
973
974 for (i = 0; i < ehdr->e_phnum; i++) {
> 975 *phdr = &phdrs[i];
976 if (!elf_phdr_valid(*phdr))
977 continue;
978
979 if ((*phdr)->p_filesz >= sizeof(struct elf_se_hdr)) {
980 addr = fw->data + (*phdr)->p_offset;
981 *pelfseg = (struct elf_se_hdr *)addr;
982
983 if ((*pelfseg)->magic == MAGIC_NUM_SE &&
984 (*pelfseg)->version == 1 &&
985 valid_seg_size(*pelfseg, (*phdr)->p_filesz))
986 if ((*pelfseg)->serial_protocol == rsc->protocol &&
987 (*pelfseg)->serial_protocol != GENI_SE_NONE)
988 return 0;
989 }
990 }
991 return -EINVAL;
992 }
993

--
0-DAY CI Kernel Test Service