Re: [PATCH v3 2/7] gpio: Add Nuvoton NCT6694 GPIO support

Ming Yu
2024-12-12T06:58:30Z

Dear Bartosz,

Thank you for your comments,

Bartosz Golaszewski <brgl@bgdev.pl> 於 2024年12月10日 週二 下午8:46寫道：
>
> Looks much better now. Please address one more issue I just noticed.
>
> > +
> > + mutex_init(&data->irq_lock);
>
> This is never destroyed. Please use devm_mutex_init() preferably to
> not add remove(). Also, the other mutex doesn't seem to be initialized
> at all.
>

Understood! I will address the issue and include the missing part in
the next patch.
For other drivers that use mutex_init() without destroying it should
also be changed to devm_mutex_init(), right?

Best regards,
Ming