Re: [PATCH v3 1/7] mfd: Add core driver for Nuvoton NCT6694

Jakub Kicinski
2024-12-11T01:56:25Z

On Tue, 10 Dec 2024 11:57:41 +0100 Mateusz Polchlopek wrote:
> > +int nct6694_read_msg(struct nct6694 *nct6694, u8 mod, u16 offset,
> > + u16 length, void *buf)
> > +{
> > + struct nct6694_cmd_header *cmd_header = nct6694->cmd_header;
> > + struct nct6694_response_header *response_header = nct6694->response_header;
>
> RCT violation

This code is not under net not drivers/net
As a general rule please focus on functional review, formatting and
process issues are harder to judge unless you read all of the mailing
list traffic.