Re: [PATCH v2 0/4] Add support for Intel CRPS PSU

Guenter Roeck
2024-12-16T18:48:17Z

On 12/16/24 09:50, Ninad Palsule wrote:
> Hello,
>
> Please review the patchset for Intel CRPS185 driver.
> V2:
> ---
> - Incorporated review comments by Guenter Roeck
> - Incorporated review comments by Krzysztof Kozlowski
>

That is not a useful change log. Please describe what you changed, not who
asked for it.

Guenter

> Ninad Palsule (4):
> hwmon: (pmbus/core) Add PMBUS_REVISION in debugfs
> hwmon: (pmbus/crps) Add Intel CRPS185 power supply
> dt-bindings: hwmon: intel,crps185: Add to trivial
> ARM: dts: aspeed: system1: Use crps PSU driver
>
> .../devicetree/bindings/trivial-devices.yaml | 2 +
> Documentation/hwmon/crps.rst | 97 +++++++++++++++++++
> Documentation/hwmon/index.rst | 1 +
> MAINTAINERS | 7 ++
> .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 8 +-
> drivers/hwmon/pmbus/Kconfig | 9 ++
> drivers/hwmon/pmbus/Makefile | 1 +
> drivers/hwmon/pmbus/crps.c | 79 +++++++++++++++
> drivers/hwmon/pmbus/pmbus_core.c | 13 ++-
> 9 files changed, 211 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/hwmon/crps.rst
> create mode 100644 drivers/hwmon/pmbus/crps.c
>