Re: [PATCH 7/9] dt-bindings: regulator: add binding for ncv6336 regulator

Krzysztof Kozlowski
2024-12-21T20:21:03Z

On 19/12/2024 17:13, Fabien Parent wrote:
>>
>>> +
>>> + compatible:
>>> + const: onnn,ncv6336
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + buck:
>>> + description: buck regulator description
>>
>> Why do you need "buck" node? Just merge the properties into this device
>> node.
>
> I decided to move the properties into a "buck" node to make the
> upstream process of the driver
> a little bit simpler. The driver is written in Rust, and if I want to
> move the properties to the device
> node I will need to provide a Rust abstraction for "struct
> device_node". I decided to avoid this

buck is already a device node, so I don't quite get how this design
avoids such abstraction, but anyway driver design choices like this do
not shape DT.

> to keep the patch series simpler by having one less abstraction to review.
> If you think that's a problem, let me know and I will implement it the
> way you are suggesting for v2.
>
Best regards,
Krzysztof