From: Tyrone Ting <warp5tw@gmail.com>
To: avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, andi.shyti@kernel.org,
andriy.shevchenko@linux.intel.com, wsa@kernel.org,
rand.sec96@gmail.com, wsa+renesas@sang-engineering.com,
warp5tw@gmail.com, tali.perry@nuvoton.com,
Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com,
KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com
Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v8 0/4] i2c: npcm: read/write operation, checkpatch
Date: Thu, 19 Dec 2024 17:08:55 +0800 [thread overview]
Message-ID: <20241219090859.18722-1-kfting@nuvoton.com> (raw)
This patchset includes the following fixes:
- Enable the target functionality in the interrupt handling routine
when the i2c transfer is about to finish.
- Correct the read/write operation procedure.
- Introduce a software flag to handle the bus error (BER) condition
which is not caused by the i2c transfer.
- Modify timeout calculation.
- Assign the client address earlier logically.
- Use an i2c frequency table for the frequency parameters assignment.
- Coding style fix.
The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards.
Addressed comments from:
- Paul Menzel : https://lore.kernel.org/lkml/67d34216-e98b-43d9-afd1-
2e73ffb71968@molgen.mpg.de/
- Andi Shyti : https://lore.kernel.org/lkml/cexpymszobfl7676acibp474e
q3qx242ppo22wrbjepxhufkvt@w4ptnmfjx7yo/
- Tali Perry : https://lore.kernel.org/lkml/CAHb3i=uT+Zx8m4hAF1M2yjCn
=a5sDBn2wJajWdCm79syuy97Ag@mail.gmail.com/
Changes since version 7:
- Modify the commit title for better description.
- Modify i2c address assignment.
Changes since version 6:
- Modify code comments.
- Remove redundant code check.
- Remove i2c address mask.
Changes since version 5:
- Correct "EAGAIN" to "-EAGAIN" in the commit message.
- Configure the bus->dest_addr by calling i2c_8bit_addr_from_msg()
and remove the I2C_M_RD flag when calling i2c_recover_bus().
- Fix the commit message which meets a too small wrapping limit.
Changes since version 4:
- Add more description for the codes.
- Modify the term "function" to "function()" in the commit message
and code comments.
Changes since version 3:
- Remove "Bug fixes" in the cover letter title.
- Modify the term "function" to "func()" in the commit message and
code comments.
- Correct the coding style.
Changes since version 2:
- Add more explanations in the commit message and code modification.
- Use lower character names for declarations.
- Remove Fixes tags in commits which are not to fix bugs.
Changes since version 1:
- Restore the npcm_i2caddr array length to fix the smatch warning.
- Remove unused variables.
- Handle the condition where scl_table_cnt reaches to the maximum value.
- Fix the checkpatch warning.
Charles Boyer (1):
i2c: npcm: Enable slave in eob interrupt
Tyrone Ting (3):
i2c: npcm: Modify timeout evaluation mechanism
i2c: npcm: Assign client address earlier for `i2c_recover_bus()`
i2c: npcm: use i2c frequency table
drivers/i2c/busses/i2c-npcm7xx.c | 427 +++++++++++++++++++++++--------
1 file changed, 326 insertions(+), 101 deletions(-)
base-commit: 663bff1ddfe4ecbba3bcf4a74646bb388b1ad5b2
--
2.34.1
next reply other threads:[~2024-12-19 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 9:08 Tyrone Ting [this message]
2024-12-19 9:08 ` [PATCH v8 1/4] i2c: npcm: Modify timeout evaluation mechanism Tyrone Ting
2024-12-19 9:08 ` [PATCH v8 2/4] i2c: npcm: Assign client address earlier for `i2c_recover_bus()` Tyrone Ting
2024-12-19 9:08 ` [PATCH v8 3/4] i2c: npcm: use i2c frequency table Tyrone Ting
2024-12-19 9:08 ` [PATCH v8 4/4] i2c: npcm: Enable slave in eob interrupt Tyrone Ting
2024-12-26 0:52 ` [PATCH v8 0/4] i2c: npcm: read/write operation, checkpatch Andi Shyti
2024-12-27 5:09 ` Tyrone Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219090859.18722-1-kfting@nuvoton.com \
--to=warp5tw@gmail.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=kfting@nuvoton.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rand.sec96@gmail.com \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox