Re: [PATCH 2/5] dt-bindings: i2c: nvidia,tegra20-i2c: Document Tegra264 I2C

Kartik Rajput
2025-01-15T11:41:45Z

On Wed, 2025-01-08 at 17:47 +0100, Thierry Reding wrote:
> On Wed, Jan 08, 2025 at 04:36:17PM +0530, Kartik Rajput wrote:
> > Tegra264 has 17 generic I2C controllers, two of which are in
> > always-on
> > partition of the SoC. In addition to the features supported by
> > Tegra194
> > it also supports a MUTEX register to allow sharing the same I2C
> > instance
> > across multiple firmware.
> >
> > Document compatible string "nvidia,tegra264-i2c" for Tegra264 I2C.
> >
> > Signed-off-by: Kartik Rajput <kkartik@nvidia.com>
> > ---
> >  .../devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml         | 6
> > ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-
> > i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-
> > i2c.yaml
> > index b57ae6963e62..2a016359328e 100644
> > --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> > @@ -80,6 +80,12 @@ properties:
> >            support for 64 KiB transactions whereas earlier chips
> > supported no
> >            more than 4 KiB per transactions.
> >          const: nvidia,tegra194-i2c
> > +      - description: |
> > +          Tegra264 has 17 generic I2C controllers, two of which
> > are in the AON
> > +          (always-on) partition of the SoC. In addition to the
> > features from
> > +          T194, a MUTEX register is added to support use of the
> > same I2C
>
> Maybe spell out Tegra194 above for consistency?
>
> > +          instance across multiple firmware.
>
> I don't know if this last sentence makes much sense in a DT bindings
> document, but doesn't hurt either. Maybe s/firmware/firmwares/.
>
> Thierry

ACK. I will update this in the next patch set.