Re: [PATCH 3/5] i2c: tegra: Add Tegra264 support

Mukesh Kumar Savaliya
2025-01-09T04:44:01Z

Hi Kartik,

On 1/8/2025 4:36 PM, Kartik Rajput wrote:
> From: Akhil R <akhilrajeev@nvidia.com>
>
> Add support for Tegra264 SoC which supports 17 generic I2C controllers,
> two of which are in the AON (always-on) partition of the SoC. Tegra264
> I2C supports all the features supported by Tegra194 I2C controllers.
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Signed-off-by: Kartik Rajput <kkartik@nvidia.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index 7b97c6d347ee..cf05937cb826 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -1646,7 +1646,35 @@ static const struct tegra_i2c_hw_feature tegra194_i2c_hw = {
> .has_hs_mode_support = true,
> };
>
> +static const struct tegra_i2c_hw_feature tegra264_i2c_hw = {
I could see 7 controllers have been already added. And this may keep
growing.
Can we make either default set which is common for most of and change
only sepcific fields ?

Second option - read these fields from DT and overwrite default if it's
mentioned in DTSI.

Please review and see if this makes sense. what others say ?
> + .has_continue_xfer_support = true,
> + .has_per_pkt_xfer_complete_irq = true,
> + .clk_divisor_hs_mode = 1,
> + .clk_divisor_std_mode = 0x1d,
> + .clk_divisor_fast_mode = 0x15,
> + .clk_divisor_fast_plus_mode = 0x8,
> + .has_config_load_reg = true,
> + .has_multi_master_mode = true,
> + .has_slcg_override_reg = true,
> + .has_mst_fifo = true,
> + .quirks = &tegra194_i2c_quirks,
> + .supports_bus_clear = true,
> + .has_apb_dma = false,
> + .tlow_std_mode = 0x8,
> + .thigh_std_mode = 0x7,
> + .tlow_fast_fastplus_mode = 0x2,
> + .thigh_fast_fastplus_mode = 0x2,
> + .tlow_hs_mode = 0x4,
> + .thigh_hs_mode = 0x2,
> + .setup_hold_time_std_mode = 0x08080808,
> + .setup_hold_time_fast_fast_plus_mode = 0x02020202,
> + .setup_hold_time_hs_mode = 0x090909,
> + .has_interface_timing_reg = true,
> + .has_hs_mode_support = true,
> +};
> +
> static const struct of_device_id tegra_i2c_of_match[] = {
> + { .compatible = "nvidia,tegra264-i2c", .data = &tegra264_i2c_hw, },
> { .compatible = "nvidia,tegra194-i2c", .data = &tegra194_i2c_hw, },
> { .compatible = "nvidia,tegra186-i2c", .data = &tegra186_i2c_hw, },
> #if IS_ENABLED(CONFIG_ARCH_TEGRA_210_SOC)