Re: [PATCH v6 7/7] rtc: Add Nuvoton NCT6694 RTC support

Alexandre Belloni
2025-02-05T10:23:49Z

On 23/01/2025 17:11:15+0800, Ming Yu wrote:
> + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> + nct6694_irq, IRQF_ONESHOT,
> + "rtc-nct6694", data);
> + if (ret < 0)
> + return dev_err_probe(&pdev->dev, ret, "Failed to request irq\n");
> +
> + ret = devm_rtc_register_device(data->rtc);
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "Failed to register rtc\n");

This message is not necessary, all the error paths of
devm_rtc_register_device already print a message

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering