Re: [PATCH 00/33] Add support for the Exynos7870 SoC, along with three devices

Krzysztof Kozlowski
2025-02-02T19:13:28Z

On 02/02/2025 19:36, Kaustabh Chakraborty wrote:
> Samsung Exynos 7870 (codename: Joshua) is an ARM-v8 system-on-chip that was
> announced in 2016. The chipset was found in several popular mid-range to
> low-end Samsung phones, released within 2016 to 2019.
>
> This patch series aims to add support for Exynos 7870, starting with the
> most basic yet essential components such as CPU, GPU, clock controllers,
> PMIC, pin controllers, etc.
>
> Moreover, the series also adds support for three Exynos 7870 devices via
> devicetree. The devices are:
> * Samsung Galaxy J7 Prime - released 2016, codename on7xelte
> * Samsung Galaxy J6 - released 2018, codename j6lte
> * Samsung Galaxy A2 Core - released 2019, codename a2corelte
>
> Additional features implemented in this series include:
> * I2C - touchscreen, IIO sensors, etc.
> * UART - bluetooth and serial debugging
> * MMC - eMMC, Wi-Fi SDIO, SDCard
> * USB - micro-USB 2.0 interface
>
> The series has commits from me and Sergey, who has given me permission
> to upstream their patches with proper attribution.
>
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
> Kaustabh Chakraborty (26):
> dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible
> dt-bindings: clock: document exynos7870 clock driver CMU bindings
> dt-bindings: soc: samsung: exynos-pmu: add exynos7870-pmu compatible
> dt-bindings: pinctrl: samsung: add exynos7870-pinctrl compatible
> dt-bindings: pinctrl: samsung: add exynos7870-wakeup-eint compatible
> dt-bindings: serial: samsung: add exynos7870-uart compatible
> dt-bindings: mfd: samsung,s2mps11: add compatible for s2mpu05-pmic

This is not related at all to this patchset.

> regulator: dt-bindings: add documentation for s2mpu05-pmic regulators

Neither is this.

> dt-bindings: phy: samsung,usb3-drd-phy: add exynos7870-usbdrd-phy compatible
> dt-bindings: usb: samsung,exynos-dwc3: add exynos7870 support
> dt-bindings: gpu: arm,mali-midgard: add exynos7870 mali compatible
> dt-bindings: i2c: samsung,s3c2410: add exynos7870-i2c compatible
> dt-bindings: i2c: exynos5: add exynos7870-hsi2c compatible
> dt-bindings: mmc: samsung,exynos-dw-mshc: add exynos7870 support
> dt-bindings: soc: samsung,boot-mode: add boot mode definitions for exynos7870
> dt-bindings: arm: samsung: add compatibles for exynos7870 devices
> soc: samsung: exynos-chipid: add support for exynos7870
> clk: samsung: add exynos7870 CLKOUT support
> tty: serial: samsung: add support for exynos7870

This goes to different patchset. Don't mix with SoC changes or pure
bindings. Your CC list is too big.

> phy: exynos5-usbdrd: fix MPLL_MULTIPLIER and SSC_REFCLKSEL masks in refclk
> phy: exynos5-usbdrd: use GENMASK and FIELD_PREP for Exynos5 PHY registers

Different patchset.

> usb: dwc3: exynos: add support for exynos7870

As well, with bindings.

Please organize your patchset according to standard SoC upstream
guidelines - don't mix SoC with non-Soc upstreaming or other subsystems.
While putting entire SoC in one patchset is tempting, you added here
totally unrelated changes like PMIC drivers. Result: 33 patches and huge
cc-list bouncing from mailing lists.

https://lore.kernel.org/linux-samsung-soc/CADrjBPq_0nUYRABKpskRF_dhHu+4K=duPVZX==0pr+cjSL_caQ@mail.gmail.com/T/#m2d9130a1342ab201ab49670fa6c858ee3724c83c

https://lore.kernel.org/all/20231121-topic-sm8650-upstream-dt-v3-0-db9d0507ffd3@linaro.org/

Best regards,
Krzysztof