Re: [PATCH v6 2/2] i2c: spacemit: add support for SpacemiT K1 SoC

Andi Shyti
2025-03-13T00:10:26Z

Hi,

On Tue, Mar 11, 2025 at 08:46:31PM -0500, Alex Elder wrote:
> On 3/7/25 7:13 AM, Troy Mitchell wrote:
> > This patch introduces basic I2C support for the SpacemiT K1 SoC,
> > utilizing interrupts for transfers.
> >
> > The driver has been tested using i2c-tools on a Bananapi-F3 board,
> > and basic I2C read/write operations have been confirmed to work.
> >
> > Signed-off-by: Troy Mitchell <troymitchell988@gmail.com>
>
> I have a bunch of really small suggestions. Please consider
> them, but whatever you choose to do this looks good to me.
>
> Reviewed-by: Alex Elder <elder@riscstar.com>

thanks Alex for reviewing, I will wait for a v7 with your
suggestions.

Overall the patch looks good to me, as well, even though I have
to give some credit to Wolfram's previous comments about the
i2c-pxa similarities.

I checked the two drivers last night and I can see some
similarities, on the other hand I also understand that it might
require some extra effort.

I want to check it again, though, before applying.

Andi