Linux I2C development
 help / color / mirror / Atom feed
From: Chukun Pan <amadeus@jmu.edu.cn>
To: ziyao@disroot.org
Cc: amadeus@jmu.edu.cn, andi.shyti@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, heiko@sntech.de, jonas@kwiboo.se,
	krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Add I2C controllers for RK3528
Date: Sun,  9 Mar 2025 16:00:25 +0800	[thread overview]
Message-ID: <20250309080025.15825-1-amadeus@jmu.edu.cn> (raw)
In-Reply-To: <20250309070603.35254-3-ziyao@disroot.org>

Hi,

> +		i2c0: i2c@ffa50000 {
> +			compatible = "rockchip,rk3528-i2c",
> +				     "rockchip,rk3399-i2c";
> +			reg = <0x0 0xffa50000 0x0 0x1000>;
> +			clocks = <&cru CLK_I2C0>, <&cru PCLK_I2C0>;
> +			clock-names = "i2c", "pclk";
> +			interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;

It would be better to add default pinctrl for all i2c nodes
using m0 group. (Only 1 group of pinctrl for i2c4 and i2c7)

Thanks,
Chukun

-- 
2.25.1


  reply	other threads:[~2025-03-09  8:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-09  7:06 [PATCH 0/3] Support I2C controllers in RK3528 Yao Zi
2025-03-09  7:06 ` [PATCH 1/3] dt-bindings: i2c: i2c-rk3x: Add compatible string for RK3528 Yao Zi
2025-03-09 19:47   ` Heiko Stübner
2025-03-10 16:38   ` Conor Dooley
2025-03-11 22:08   ` Andi Shyti
2025-03-09  7:06 ` [PATCH 2/3] arm64: dts: rockchip: Add I2C controllers " Yao Zi
2025-03-09  8:00   ` Chukun Pan [this message]
2025-03-10  7:22     ` Yao Zi
2025-03-09 18:23   ` Jonas Karlman
2025-03-09  7:06 ` [PATCH 3/3] arm64: dts: rockchip: Add onboard EEPROM for Radxa E20C Yao Zi
2025-03-10  7:00   ` Chukun Pan
2025-03-10  7:15     ` Yao Zi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250309080025.15825-1-amadeus@jmu.edu.cn \
    --to=amadeus@jmu.edu.cn \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox