From: Enrico Zanda <e.zanda1@gmail.com>
To: linux-i2c@vger.kernel.org
Cc: andi.shyti@kernel.org, Enrico Zanda <e.zanda1@gmail.com>
Subject: [PATCH 02/10] i2c: uniphier: Replace dev_err() with dev_err_probe() in probe function
Date: Tue, 15 Apr 2025 20:34:39 +0200 [thread overview]
Message-ID: <20250415183447.396277-3-e.zanda1@gmail.com> (raw)
In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com>
This simplifies the code while improving log.
Signed-off-by: Enrico Zanda <e.zanda1@gmail.com>
---
drivers/i2c/busses/i2c-uniphier.c | 24 ++++++++----------------
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/i2c/busses/i2c-uniphier.c b/drivers/i2c/busses/i2c-uniphier.c
index b95d50d4d7db..9d49a3d5d612 100644
--- a/drivers/i2c/busses/i2c-uniphier.c
+++ b/drivers/i2c/busses/i2c-uniphier.c
@@ -327,22 +327,16 @@ static int uniphier_i2c_probe(struct platform_device *pdev)
if (of_property_read_u32(dev->of_node, "clock-frequency", &bus_speed))
bus_speed = I2C_MAX_STANDARD_MODE_FREQ;
- if (!bus_speed || bus_speed > I2C_MAX_FAST_MODE_FREQ) {
- dev_err(dev, "invalid clock-frequency %d\n", bus_speed);
- return -EINVAL;
- }
+ if (!bus_speed || bus_speed > I2C_MAX_FAST_MODE_FREQ)
+ return dev_err_probe(dev, -EINVAL, "invalid clock-frequency %d\n", bus_speed);
priv->clk = devm_clk_get_enabled(dev, NULL);
- if (IS_ERR(priv->clk)) {
- dev_err(dev, "failed to enable clock\n");
- return PTR_ERR(priv->clk);
- }
+ if (IS_ERR(priv->clk))
+ return dev_err_probe(dev, PTR_ERR(priv->clk), "failed to enable clock\n");
clk_rate = clk_get_rate(priv->clk);
- if (!clk_rate) {
- dev_err(dev, "input clock rate should not be zero\n");
- return -EINVAL;
- }
+ if (!clk_rate)
+ return dev_err_probe(dev, -EINVAL, "input clock rate should not be zero\n");
priv->clk_cycle = clk_rate / bus_speed;
init_completion(&priv->comp);
@@ -359,10 +353,8 @@ static int uniphier_i2c_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, irq, uniphier_i2c_interrupt, 0, pdev->name,
priv);
- if (ret) {
- dev_err(dev, "failed to request irq %d\n", irq);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to request irq %d\n", irq);
return i2c_add_adapter(&priv->adap);
}
--
2.43.0
next prev parent reply other threads:[~2025-04-15 18:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 18:34 [PATCH 00/10] i2c: Replace dev_err() with dev_err_probe() Enrico Zanda
2025-04-15 18:34 ` [PATCH 01/10] i2c: uniphier(-f): Replace dev_err() with dev_err_probe() in probe function Enrico Zanda
2025-04-15 18:34 ` Enrico Zanda [this message]
2025-04-15 18:34 ` [PATCH 03/10] i2c: via: " Enrico Zanda
2025-04-16 20:44 ` Andi Shyti
2025-04-15 18:34 ` [PATCH 04/10] i2c: viai2c-wmt: " Enrico Zanda
2025-04-16 20:42 ` Andi Shyti
2025-05-13 21:00 ` Enrico Zanda
2025-04-15 18:34 ` [PATCH 05/10] i2c: viapro: " Enrico Zanda
2025-04-16 21:12 ` Andi Shyti
2025-04-15 18:34 ` [PATCH 06/10] i2c: viperboard: " Enrico Zanda
2025-04-15 18:34 ` [PATCH 07/10] i2c: virtio: " Enrico Zanda
2025-04-15 18:34 ` [PATCH 08/10] i2c: xgene-slimpro: " Enrico Zanda
2025-04-16 21:19 ` Andi Shyti
2025-05-11 19:55 ` Enrico Zanda
2025-04-15 18:34 ` [PATCH 09/10] i2c: i2c-xiic: " Enrico Zanda
2025-04-15 18:34 ` [PATCH 10/10] i2c: scx200_acb: " Enrico Zanda
2025-04-16 21:49 ` [PATCH 00/10] i2c: Replace dev_err() with dev_err_probe() Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415183447.396277-3-e.zanda1@gmail.com \
--to=e.zanda1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).